Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24648002: Rename CallbackRegistry to CallbackList (Closed)

Created:
7 years, 2 months ago by Cait (Slow)
Modified:
7 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Doc fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -1120 lines) Patch
M base/base.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + base/callback_list.h View 1 20 chunks +67 lines, -67 lines 0 comments Download
A + base/callback_list.h.pump View 1 12 chunks +29 lines, -28 lines 0 comments Download
A + base/callback_list_unittest.cc View 11 chunks +42 lines, -42 lines 0 comments Download
A + base/callback_list_unittest.nc View 2 chunks +4 lines, -4 lines 0 comments Download
D base/callback_registry.h View 1 chunk +0 lines, -385 lines 0 comments Download
D base/callback_registry.h.pump View 1 chunk +0 lines, -243 lines 0 comments Download
D base/callback_registry_unittest.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D base/callback_registry_unittest.nc View 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/user_style_sheet_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/user_style_sheet_watcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cait (Slow)
PTAL -- thanks!
7 years, 2 months ago (2013-09-25 19:30:38 UTC) #1
awong
LGTM Oh! I was going to do this since naming it wrong was my fault. ...
7 years, 2 months ago (2013-09-25 19:43:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/24648002/3001
7 years, 2 months ago (2013-09-25 20:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/24648002/3001
7 years, 2 months ago (2013-09-25 22:00:05 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 19:20:22 UTC) #5
Message was sent while issue was closed. 
Change committed as 225534

Powered by Google App Engine
This is Rietveld 408576698