Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Issue 2464783002: Disabling flaky WebRtcGetUserMediaBrowserTest.TwoGet...1080pSecondVga. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/json/json_reader.h" 8 #include "base/json/json_reader.h"
9 #include "base/memory/ref_counted_memory.h" 9 #include "base/memory/ref_counted_memory.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 std::string constraints1 = 511 std::string constraints1 =
512 "{video: {mandatory: {maxWidth:1280 , minWidth:1280 , maxHeight: 720,\ 512 "{video: {mandatory: {maxWidth:1280 , minWidth:1280 , maxHeight: 720,\
513 minHeight: 720}}}"; 513 minHeight: 720}}}";
514 std::string constraints2 = 514 std::string constraints2 =
515 "{video: {mandatory: {maxWidth:640 , maxHeight: 480}}}"; 515 "{video: {mandatory: {maxWidth:640 , maxHeight: 480}}}";
516 std::string expected_result = "w=1280:h=720-w=640:h=480"; 516 std::string expected_result = "w=1280:h=720-w=640:h=480";
517 RunTwoGetTwoGetUserMediaWithDifferentContraints(constraints1, constraints2, 517 RunTwoGetTwoGetUserMediaWithDifferentContraints(constraints1, constraints2,
518 expected_result); 518 expected_result);
519 } 519 }
520 520
521 #if defined(OS_WIN) 521 // Timing out on Windows 7 bot: http://crbug.com/443294
522 // Timing out on Winodws 7 bot: http://crbug.com/443294 522 // Flaky: http://crbug.com/660656; possible the test is too perf sensitive.
523 #define MAYBE_TwoGetUserMediaWithFirst1080pSecondVga\
524 DISABLED_TwoGetUserMediaWithFirst1080pSecondVga
525 #else
526 #define MAYBE_TwoGetUserMediaWithFirst1080pSecondVga\
527 TwoGetUserMediaWithFirst1080pSecondVga
528 #endif
529
530 IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest, 523 IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
531 MAYBE_TwoGetUserMediaWithFirst1080pSecondVga) { 524 DISABLED_TwoGetUserMediaWithFirst1080pSecondVga) {
532 std::string constraints1 = 525 std::string constraints1 =
533 "{video: {mandatory: {maxWidth:1920 , minWidth:1920 , maxHeight: 1080,\ 526 "{video: {mandatory: {maxWidth:1920 , minWidth:1920 , maxHeight: 1080,\
534 minHeight: 1080}}}"; 527 minHeight: 1080}}}";
535 std::string constraints2 = 528 std::string constraints2 =
536 "{video: {mandatory: {maxWidth:640 , maxHeight: 480}}}"; 529 "{video: {mandatory: {maxWidth:640 , maxHeight: 480}}}";
537 std::string expected_result = "w=1920:h=1080-w=640:h=480"; 530 std::string expected_result = "w=1920:h=1080-w=640:h=480";
538 RunTwoGetTwoGetUserMediaWithDifferentContraints(constraints1, constraints2, 531 RunTwoGetTwoGetUserMediaWithDifferentContraints(constraints1, constraints2,
539 expected_result); 532 expected_result);
540 } 533 }
541 534
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 base::Bind(&VerifyDisableLocalEcho, true)); 757 base::Bind(&VerifyDisableLocalEcho, true));
765 call = GenerateGetUserMediaWithDisableLocalEcho( 758 call = GenerateGetUserMediaWithDisableLocalEcho(
766 "getUserMediaAndExpectSuccess", "true"); 759 "getUserMediaAndExpectSuccess", "true");
767 ExecuteJavascriptAndWaitForOk(call); 760 ExecuteJavascriptAndWaitForOk(call);
768 761
769 manager->SetGenerateStreamCallbackForTesting( 762 manager->SetGenerateStreamCallbackForTesting(
770 MediaStreamManager::GenerateStreamTestCallback()); 763 MediaStreamManager::GenerateStreamTestCallback());
771 } 764 }
772 765
773 } // namespace content 766 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698