Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2464743002: Revert of Disable flaky WebRTC tests. (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years, 1 month ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky WebRTC tests. (patchset #2 id:20001 of https://codereview.chromium.org/2401863002/ ) Reason for revert: Let's see if the NOTREACHED is still hitting. Original issue's description: > Disable flaky WebRTC tests. > > BUG=webrtc:6484 > TBR=phoglund@chromium.org > > Committed: https://crrev.com/64afe822cc7ce28b470172f89116fb5234e3e2ee > Cr-Commit-Position: refs/heads/master@{#423834} TBR=guidou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6484, 659124 Committed: https://crrev.com/45cec35789b4d3042e2c17604d6597bbf6ed412a Cr-Commit-Position: refs/heads/master@{#428668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
M chrome/browser/media/webrtc/webrtc_perf_browsertest.cc View 3 chunks +7 lines, -25 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc View 1 chunk +3 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
phoglund_chromium
Created Revert of Disable flaky WebRTC tests.
4 years, 1 month ago (2016-10-31 08:27:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464743002/1
4 years, 1 month ago (2016-10-31 08:27:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 09:01:16 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 09:07:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45cec35789b4d3042e2c17604d6597bbf6ed412a
Cr-Commit-Position: refs/heads/master@{#428668}

Powered by Google App Engine
This is Rietveld 408576698