Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issue 2464733003: Remove --harmony-* flags for new Object static methods (Closed)

Created:
4 years, 1 month ago by adamk
Modified:
4 years, 1 month ago
Reviewers:
caitp
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-* flags for new Object static methods Both --harmony-object-values-entries and --harmony-object-own-property-descriptors are on by default in v8 5.4, which has now shipped to stable as Chrome 54. R=caitp@igalia.com Committed: https://crrev.com/a1381990a7e6cb86e6f009b62fce7c9fe010722f Cr-Commit-Position: refs/heads/master@{#40683}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move tests to es8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -884 lines) Patch
M src/bootstrapper.cc View 4 chunks +7 lines, -32 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +4 lines, -7 lines 0 comments Download
A + test/mjsunit/es8/object-entries.js View 1 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es8/object-get-own-property-descriptors.js View 1 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es8/object-values.js View 1 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/harmony/object-entries.js View 1 chunk +0 lines, -315 lines 0 comments Download
D test/mjsunit/harmony/object-get-own-property-descriptors.js View 1 chunk +0 lines, -235 lines 0 comments Download
D test/mjsunit/harmony/object-values.js View 1 chunk +0 lines, -292 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
adamk
4 years, 1 month ago (2016-10-31 21:34:56 UTC) #1
caitp
lgtm https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js File test/mjsunit/object-entries.js (left): https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js#oldcode6 test/mjsunit/object-entries.js:6: // Flags: --allow-natives-syntax Don't we normally put these ...
4 years, 1 month ago (2016-10-31 21:37:20 UTC) #4
adamk
https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js File test/mjsunit/object-entries.js (left): https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js#oldcode6 test/mjsunit/object-entries.js:6: // Flags: --allow-natives-syntax On 2016/10/31 21:37:20, caitp wrote: > ...
4 years, 1 month ago (2016-10-31 21:39:46 UTC) #5
caitp
https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js File test/mjsunit/object-entries.js (left): https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js#oldcode6 test/mjsunit/object-entries.js:6: // Flags: --allow-natives-syntax On 2016/10/31 21:39:46, adamk wrote: > ...
4 years, 1 month ago (2016-10-31 22:11:23 UTC) #8
adamk
On 2016/10/31 22:11:23, caitp wrote: > https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js > File test/mjsunit/object-entries.js (left): > > https://codereview.chromium.org/2464733003/diff/1/test/mjsunit/object-entries.js#oldcode6 > ...
4 years, 1 month ago (2016-10-31 22:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464733003/20001
4 years, 1 month ago (2016-10-31 22:28:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 22:53:03 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:39 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1381990a7e6cb86e6f009b62fce7c9fe010722f
Cr-Commit-Position: refs/heads/master@{#40683}

Powered by Google App Engine
This is Rietveld 408576698