Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: xfa/fwl/core/ifwl_tooltip.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/ifwl_tooltip.h ('k') | xfa/fwl/core/ifwl_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/ifwl_tooltip.cpp
diff --git a/xfa/fwl/core/ifwl_tooltip.cpp b/xfa/fwl/core/ifwl_tooltip.cpp
index 815670ed75aede3737bf3e1e9b22f7b9be6e26b9..371709772ef3d3a86cccc5458f172dc60776e4b4 100644
--- a/xfa/fwl/core/ifwl_tooltip.cpp
+++ b/xfa/fwl/core/ifwl_tooltip.cpp
@@ -6,6 +6,7 @@
#include "xfa/fwl/core/ifwl_tooltip.h"
+#include "third_party/base/ptr_util.h"
#include "xfa/fde/tto/fde_textout.h"
#include "xfa/fwl/core/cfwl_themebackground.h"
#include "xfa/fwl/core/cfwl_themepart.h"
@@ -29,24 +30,13 @@ IFWL_ToolTip::IFWL_ToolTip(const IFWL_App* app,
m_rtClient.Set(0, 0, 0, 0);
m_rtCaption.Set(0, 0, 0, 0);
m_rtAnchor.Set(0, 0, 0, 0);
-}
-
-IFWL_ToolTip::~IFWL_ToolTip() {}
-
-void IFWL_ToolTip::Initialize() {
- IFWL_Widget::Initialize();
-
- m_pProperties->m_dwStyles |= FWL_WGTSTYLE_Popup;
m_pProperties->m_dwStyles &= ~FWL_WGTSTYLE_Child;
+ m_pProperties->m_dwStyles |= FWL_WGTSTYLE_Popup;
- m_pDelegate = new CFWL_ToolTipImpDelegate(this);
+ SetDelegate(pdfium::MakeUnique<CFWL_ToolTipImpDelegate>(this));
}
-void IFWL_ToolTip::Finalize() {
- delete m_pDelegate;
- m_pDelegate = nullptr;
- IFWL_Widget::Finalize();
-}
+IFWL_ToolTip::~IFWL_ToolTip() {}
FWL_Type IFWL_ToolTip::GetClassID() const {
return FWL_Type::ToolTip;
« no previous file with comments | « xfa/fwl/core/ifwl_tooltip.h ('k') | xfa/fwl/core/ifwl_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698