Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: xfa/fwl/core/ifwl_picturebox.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/ifwl_picturebox.h ('k') | xfa/fwl/core/ifwl_pushbutton.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/ifwl_picturebox.cpp
diff --git a/xfa/fwl/core/ifwl_picturebox.cpp b/xfa/fwl/core/ifwl_picturebox.cpp
index 20ab54a37cdf13b25b9e9f9554725d0010e38d21..50bf2a40ea043cb7ff1fde09824ecece0b63136c 100644
--- a/xfa/fwl/core/ifwl_picturebox.cpp
+++ b/xfa/fwl/core/ifwl_picturebox.cpp
@@ -6,6 +6,7 @@
#include "xfa/fwl/core/ifwl_picturebox.h"
+#include "third_party/base/ptr_util.h"
#include "xfa/fwl/core/cfwl_picturebox.h"
#include "xfa/fwl/core/fwl_noteimp.h"
@@ -18,20 +19,11 @@ IFWL_PictureBox::IFWL_PictureBox(const IFWL_App* app,
m_rtClient.Reset();
m_rtImage.Reset();
m_matrix.SetIdentity();
-}
-
-IFWL_PictureBox::~IFWL_PictureBox() {}
-void IFWL_PictureBox::Initialize() {
- IFWL_Widget::Initialize();
- m_pDelegate = new CFWL_PictureBoxImpDelegate(this);
+ SetDelegate(pdfium::MakeUnique<CFWL_PictureBoxImpDelegate>(this));
}
-void IFWL_PictureBox::Finalize() {
- delete m_pDelegate;
- m_pDelegate = nullptr;
- IFWL_Widget::Finalize();
-}
+IFWL_PictureBox::~IFWL_PictureBox() {}
FWL_Type IFWL_PictureBox::GetClassID() const {
return FWL_Type::PictureBox;
« no previous file with comments | « xfa/fwl/core/ifwl_picturebox.h ('k') | xfa/fwl/core/ifwl_pushbutton.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698