Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: xfa/fwl/core/cfwl_combobox.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_checkbox.cpp ('k') | xfa/fwl/core/cfwl_datetimepicker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_combobox.cpp
diff --git a/xfa/fwl/core/cfwl_combobox.cpp b/xfa/fwl/core/cfwl_combobox.cpp
index ed5262ee29be3fecd7532ec6813f851321f7dbaf..3d458428725ebc214ec5b28d20ad716333e81024 100644
--- a/xfa/fwl/core/cfwl_combobox.cpp
+++ b/xfa/fwl/core/cfwl_combobox.cpp
@@ -8,6 +8,7 @@
#include <utility>
+#include "third_party/base/ptr_util.h"
#include "xfa/fwl/core/fwl_error.h"
#include "xfa/fwl/core/ifwl_widget.h"
@@ -30,11 +31,9 @@ CFWL_ComboBox::~CFWL_ComboBox() {}
void CFWL_ComboBox::Initialize() {
ASSERT(!m_pIface);
- std::unique_ptr<IFWL_ComboBox> pComboBox(new IFWL_ComboBox(
- m_pApp, m_pProperties->MakeWidgetImpProperties(&m_comboBoxData)));
- pComboBox->Initialize();
+ m_pIface = pdfium::MakeUnique<IFWL_ComboBox>(
+ m_pApp, m_pProperties->MakeWidgetImpProperties(&m_comboBoxData));
- m_pIface = std::move(pComboBox);
CFWL_Widget::Initialize();
}
« no previous file with comments | « xfa/fwl/core/cfwl_checkbox.cpp ('k') | xfa/fwl/core/cfwl_datetimepicker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698