Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: xfa/fwl/core/cfwl_barcode.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_checkbox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_barcode.cpp
diff --git a/xfa/fwl/core/cfwl_barcode.cpp b/xfa/fwl/core/cfwl_barcode.cpp
index bf7baa37e81570f9f0669ee346f27b3f7ace65f5..a23bd16df3ad02bd58d34b8a85c74885ae946968 100644
--- a/xfa/fwl/core/cfwl_barcode.cpp
+++ b/xfa/fwl/core/cfwl_barcode.cpp
@@ -8,6 +8,8 @@
#include <memory>
+#include "third_party/base/ptr_util.h"
+
namespace {
IFWL_Barcode* ToBarcode(IFWL_Widget* widget) {
@@ -22,11 +24,10 @@ CFWL_Barcode::~CFWL_Barcode() {}
void CFWL_Barcode::Initialize() {
ASSERT(!m_pIface);
- std::unique_ptr<IFWL_Barcode> pBarcode(new IFWL_Barcode(
- m_pApp, m_pProperties->MakeWidgetImpProperties(&m_barcodeData)));
- pBarcode->Initialize();
- m_pIface = std::move(pBarcode);
+ m_pIface = pdfium::MakeUnique<IFWL_Barcode>(
+ m_pApp, m_pProperties->MakeWidgetImpProperties(&m_barcodeData));
+
CFWL_Widget::Initialize();
}
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_checkbox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698