Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: xfa/fwl/core/cfwl_edit.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/core/cfwl_edit.cpp
diff --git a/xfa/fwl/core/cfwl_edit.cpp b/xfa/fwl/core/cfwl_edit.cpp
index 3ce1bcf2479b465254ee820bba0f3532d9ecb943..4b6769e2b14d60bcf26eb5f8fd72f2bde6084698 100644
--- a/xfa/fwl/core/cfwl_edit.cpp
+++ b/xfa/fwl/core/cfwl_edit.cpp
@@ -9,6 +9,8 @@
#include <memory>
#include <vector>
+#include "third_party/base/ptr_util.h"
+
namespace {
IFWL_Edit* ToEdit(IFWL_Widget* widget) {
@@ -28,11 +30,9 @@ CFWL_Edit::~CFWL_Edit() {}
void CFWL_Edit::Initialize() {
ASSERT(!m_pIface);
- std::unique_ptr<IFWL_Edit> pEdit(new IFWL_Edit(
- m_pApp, m_pProperties->MakeWidgetImpProperties(nullptr), nullptr));
- pEdit->Initialize();
+ m_pIface = pdfium::MakeUnique<IFWL_Edit>(
+ m_pApp, m_pProperties->MakeWidgetImpProperties(nullptr), nullptr);
- m_pIface = std::move(pEdit);
CFWL_Widget::Initialize();
}

Powered by Google App Engine
This is Rietveld 408576698