Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: xfa/fwl/core/cfwl_edit.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_datetimepicker.cpp ('k') | xfa/fwl/core/cfwl_listbox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/core/cfwl_edit.h" 7 #include "xfa/fwl/core/cfwl_edit.h"
8 8
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
11 11
12 #include "third_party/base/ptr_util.h"
13
12 namespace { 14 namespace {
13 15
14 IFWL_Edit* ToEdit(IFWL_Widget* widget) { 16 IFWL_Edit* ToEdit(IFWL_Widget* widget) {
15 return static_cast<IFWL_Edit*>(widget); 17 return static_cast<IFWL_Edit*>(widget);
16 } 18 }
17 19
18 const IFWL_Edit* ToEdit(const IFWL_Widget* widget) { 20 const IFWL_Edit* ToEdit(const IFWL_Widget* widget) {
19 return static_cast<const IFWL_Edit*>(widget); 21 return static_cast<const IFWL_Edit*>(widget);
20 } 22 }
21 23
22 } // namespace 24 } // namespace
23 25
24 CFWL_Edit::CFWL_Edit(const IFWL_App* app) : CFWL_Widget(app) {} 26 CFWL_Edit::CFWL_Edit(const IFWL_App* app) : CFWL_Widget(app) {}
25 27
26 CFWL_Edit::~CFWL_Edit() {} 28 CFWL_Edit::~CFWL_Edit() {}
27 29
28 void CFWL_Edit::Initialize() { 30 void CFWL_Edit::Initialize() {
29 ASSERT(!m_pIface); 31 ASSERT(!m_pIface);
30 32
31 std::unique_ptr<IFWL_Edit> pEdit(new IFWL_Edit( 33 m_pIface = pdfium::MakeUnique<IFWL_Edit>(
32 m_pApp, m_pProperties->MakeWidgetImpProperties(nullptr), nullptr)); 34 m_pApp, m_pProperties->MakeWidgetImpProperties(nullptr), nullptr);
33 pEdit->Initialize();
34 35
35 m_pIface = std::move(pEdit);
36 CFWL_Widget::Initialize(); 36 CFWL_Widget::Initialize();
37 } 37 }
38 38
39 FWL_Error CFWL_Edit::SetText(const CFX_WideString& wsText) { 39 FWL_Error CFWL_Edit::SetText(const CFX_WideString& wsText) {
40 if (!GetWidget()) 40 if (!GetWidget())
41 return FWL_Error::Indefinite; 41 return FWL_Error::Indefinite;
42 return ToEdit(GetWidget())->SetText(wsText); 42 return ToEdit(GetWidget())->SetText(wsText);
43 } 43 }
44 44
45 int32_t CFWL_Edit::GetTextLength() const { 45 int32_t CFWL_Edit::GetTextLength() const {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 228
229 FX_BOOL CFWL_Edit::GetSuggestWords(CFX_PointF pointf, 229 FX_BOOL CFWL_Edit::GetSuggestWords(CFX_PointF pointf,
230 std::vector<CFX_ByteString>& sSuggest) { 230 std::vector<CFX_ByteString>& sSuggest) {
231 return ToEdit(GetWidget())->GetSuggestWords(pointf, sSuggest); 231 return ToEdit(GetWidget())->GetSuggestWords(pointf, sSuggest);
232 } 232 }
233 233
234 FX_BOOL CFWL_Edit::ReplaceSpellCheckWord(CFX_PointF pointf, 234 FX_BOOL CFWL_Edit::ReplaceSpellCheckWord(CFX_PointF pointf,
235 const CFX_ByteStringC& bsReplace) { 235 const CFX_ByteStringC& bsReplace) {
236 return ToEdit(GetWidget())->ReplaceSpellCheckWord(pointf, bsReplace); 236 return ToEdit(GetWidget())->ReplaceSpellCheckWord(pointf, bsReplace);
237 } 237 }
OLDNEW
« no previous file with comments | « xfa/fwl/core/cfwl_datetimepicker.cpp ('k') | xfa/fwl/core/cfwl_listbox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698