Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Side by Side Diff: xfa/fwl/core/cfwl_datetimepicker.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_combobox.cpp ('k') | xfa/fwl/core/cfwl_edit.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/core/cfwl_datetimepicker.h" 7 #include "xfa/fwl/core/cfwl_datetimepicker.h"
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "third_party/base/ptr_util.h"
11 #include "xfa/fwl/core/fwl_error.h" 12 #include "xfa/fwl/core/fwl_error.h"
12 #include "xfa/fwl/core/ifwl_datetimepicker.h" 13 #include "xfa/fwl/core/ifwl_datetimepicker.h"
13 #include "xfa/fwl/core/ifwl_widget.h" 14 #include "xfa/fwl/core/ifwl_widget.h"
14 15
15 namespace { 16 namespace {
16 17
17 IFWL_DateTimePicker* ToDateTimePicker(IFWL_Widget* widget) { 18 IFWL_DateTimePicker* ToDateTimePicker(IFWL_Widget* widget) {
18 return static_cast<IFWL_DateTimePicker*>(widget); 19 return static_cast<IFWL_DateTimePicker*>(widget);
19 } 20 }
20 21
21 } // namespace 22 } // namespace
22 23
23 CFWL_DateTimePicker::CFWL_DateTimePicker(const IFWL_App* app) 24 CFWL_DateTimePicker::CFWL_DateTimePicker(const IFWL_App* app)
24 : CFWL_Widget(app) {} 25 : CFWL_Widget(app) {}
25 26
26 CFWL_DateTimePicker::~CFWL_DateTimePicker() {} 27 CFWL_DateTimePicker::~CFWL_DateTimePicker() {}
27 28
28 void CFWL_DateTimePicker::Initialize() { 29 void CFWL_DateTimePicker::Initialize() {
29 ASSERT(!m_pIface); 30 ASSERT(!m_pIface);
30 31
31 std::unique_ptr<IFWL_DateTimePicker> pDateTimePicker(new IFWL_DateTimePicker( 32 m_pIface = pdfium::MakeUnique<IFWL_DateTimePicker>(
32 m_pApp, m_pProperties->MakeWidgetImpProperties(&m_DateTimePickerDP))); 33 m_pApp, m_pProperties->MakeWidgetImpProperties(&m_DateTimePickerDP));
33 pDateTimePicker->Initialize();
34 34
35 m_pIface = std::move(pDateTimePicker);
36 CFWL_Widget::Initialize(); 35 CFWL_Widget::Initialize();
37 } 36 }
38 37
39 FWL_Error CFWL_DateTimePicker::SetToday(int32_t iYear, 38 FWL_Error CFWL_DateTimePicker::SetToday(int32_t iYear,
40 int32_t iMonth, 39 int32_t iMonth,
41 int32_t iDay) { 40 int32_t iDay) {
42 m_DateTimePickerDP.m_iYear = iYear; 41 m_DateTimePickerDP.m_iYear = iYear;
43 m_DateTimePickerDP.m_iMonth = iMonth; 42 m_DateTimePickerDP.m_iMonth = iMonth;
44 m_DateTimePickerDP.m_iDay = iDay; 43 m_DateTimePickerDP.m_iDay = iDay;
45 return FWL_Error::Succeeded; 44 return FWL_Error::Succeeded;
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 154
156 FWL_Error CFWL_DateTimePicker::SetEditLimit(int32_t nLimit) { 155 FWL_Error CFWL_DateTimePicker::SetEditLimit(int32_t nLimit) {
157 return ToDateTimePicker(GetWidget())->SetEditLimit(nLimit); 156 return ToDateTimePicker(GetWidget())->SetEditLimit(nLimit);
158 } 157 }
159 158
160 FWL_Error CFWL_DateTimePicker::ModifyEditStylesEx(uint32_t dwStylesExAdded, 159 FWL_Error CFWL_DateTimePicker::ModifyEditStylesEx(uint32_t dwStylesExAdded,
161 uint32_t dwStylesExRemoved) { 160 uint32_t dwStylesExRemoved) {
162 return ToDateTimePicker(GetWidget()) 161 return ToDateTimePicker(GetWidget())
163 ->ModifyEditStylesEx(dwStylesExAdded, dwStylesExRemoved); 162 ->ModifyEditStylesEx(dwStylesExAdded, dwStylesExRemoved);
164 } 163 }
OLDNEW
« no previous file with comments | « xfa/fwl/core/cfwl_combobox.cpp ('k') | xfa/fwl/core/cfwl_edit.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698