Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: xfa/fwl/core/cfwl_checkbox.cpp

Issue 2464703006: Fold IFWL*::{Initialize|Finalize} into constructor/destructor (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_barcode.cpp ('k') | xfa/fwl/core/cfwl_combobox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/core/cfwl_checkbox.h" 7 #include "xfa/fwl/core/cfwl_checkbox.h"
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "third_party/base/ptr_util.h"
11 #include "xfa/fwl/core/fwl_error.h" 12 #include "xfa/fwl/core/fwl_error.h"
12 13
13 namespace { 14 namespace {
14 15
15 IFWL_CheckBox* ToCheckBox(IFWL_Widget* widget) { 16 IFWL_CheckBox* ToCheckBox(IFWL_Widget* widget) {
16 return static_cast<IFWL_CheckBox*>(widget); 17 return static_cast<IFWL_CheckBox*>(widget);
17 } 18 }
18 19
19 } // namespace 20 } // namespace
20 21
21 CFWL_CheckBox::CFWL_CheckBox(const IFWL_App* app) : CFWL_Widget(app) {} 22 CFWL_CheckBox::CFWL_CheckBox(const IFWL_App* app) : CFWL_Widget(app) {}
22 23
23 CFWL_CheckBox::~CFWL_CheckBox() {} 24 CFWL_CheckBox::~CFWL_CheckBox() {}
24 25
25 void CFWL_CheckBox::Initialize() { 26 void CFWL_CheckBox::Initialize() {
26 ASSERT(!m_pIface); 27 ASSERT(!m_pIface);
27 28
28 std::unique_ptr<IFWL_CheckBox> pCheckBox(new IFWL_CheckBox( 29 m_pIface = pdfium::MakeUnique<IFWL_CheckBox>(
29 m_pApp, m_pProperties->MakeWidgetImpProperties(&m_checkboxData))); 30 m_pApp, m_pProperties->MakeWidgetImpProperties(&m_checkboxData));
30 pCheckBox->Initialize();
31 31
32 m_pIface = std::move(pCheckBox);
33 CFWL_Widget::Initialize(); 32 CFWL_Widget::Initialize();
34 } 33 }
35 34
36 FWL_Error CFWL_CheckBox::SetCaption(const CFX_WideStringC& wsCaption) { 35 FWL_Error CFWL_CheckBox::SetCaption(const CFX_WideStringC& wsCaption) {
37 m_checkboxData.m_wsCaption = wsCaption; 36 m_checkboxData.m_wsCaption = wsCaption;
38 return FWL_Error::Succeeded; 37 return FWL_Error::Succeeded;
39 } 38 }
40 39
41 FWL_Error CFWL_CheckBox::SetBoxSize(FX_FLOAT fHeight) { 40 FWL_Error CFWL_CheckBox::SetBoxSize(FX_FLOAT fHeight) {
42 m_checkboxData.m_fBoxHeight = fHeight; 41 m_checkboxData.m_fBoxHeight = fHeight;
(...skipping 14 matching lines...) Expand all
57 FWL_Error CFWL_CheckBox::CFWL_CheckBoxDP::GetCaption( 56 FWL_Error CFWL_CheckBox::CFWL_CheckBoxDP::GetCaption(
58 IFWL_Widget* pWidget, 57 IFWL_Widget* pWidget,
59 CFX_WideString& wsCaption) { 58 CFX_WideString& wsCaption) {
60 wsCaption = m_wsCaption; 59 wsCaption = m_wsCaption;
61 return FWL_Error::Succeeded; 60 return FWL_Error::Succeeded;
62 } 61 }
63 62
64 FX_FLOAT CFWL_CheckBox::CFWL_CheckBoxDP::GetBoxSize(IFWL_Widget* pWidget) { 63 FX_FLOAT CFWL_CheckBox::CFWL_CheckBoxDP::GetBoxSize(IFWL_Widget* pWidget) {
65 return m_fBoxHeight; 64 return m_fBoxHeight;
66 } 65 }
OLDNEW
« no previous file with comments | « xfa/fwl/core/cfwl_barcode.cpp ('k') | xfa/fwl/core/cfwl_combobox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698