Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2464703003: MIPS64: Fix NoBarrierAtomicValue.Construction test failure on big-endian (Closed)

Created:
4 years, 1 month ago by predrag.rudic
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix NoBarrierAtomicValue.Construction test failure on big-endian Reason for the failure is that the test enumeration is 32-bit wide, whereas AtomicWord is 64-bit wide on 64-bit machines. On 64-big endian, this loads the random four bytes located after the 32-bit value that is tested. BUG= TEST=unittests/NoBarrierAtomicValue.Construction Committed: https://crrev.com/586e4a8951154374079c2b9a8e78119dcded51b6 Cr-Commit-Position: refs/heads/master@{#40767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/unittests/base/atomic-utils-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
ivica.bogosavljevic
4 years, 1 month ago (2016-11-03 12:57:19 UTC) #2
predrag.rudic
PTAL
4 years, 1 month ago (2016-11-03 13:03:13 UTC) #5
Michael Lippautz
lgtm
4 years, 1 month ago (2016-11-03 15:16:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464703003/1
4 years, 1 month ago (2016-11-04 13:19:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 13:44:52 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/586e4a8951154374079c2b9a8e78119dcded51b6
Cr-Commit-Position: refs/heads/master@{#40767}

Powered by Google App Engine
This is Rietveld 408576698