Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2464693004: Fix mojom::ResourceUsageReporter exposure via content child capabilities (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, kalyank, qsr+mojo_chromium.org, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mojom::ResourceUsageReporter exposure via content child capabilities Adds the interface to the browser capability for content_gpu in Chrome's overlay. Moves the interface from content_renderer_manifest.json to Chrome's content_renderer overlay where it belongs. Adds a Chrome overlay for content_plugin and adds the interface there as well. BUG=660903 R=ben@chromium.org,tsepez@chromium.org Committed: https://crrev.com/67c1db0e0886747ccb550b0df67394cfa5d5f312 Cr-Commit-Position: refs/heads/master@{#428804}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M chrome/app/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/app/mash/mash_service_overrides.json View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_gpu_manifest_overlay.json View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/chrome_content_plugin_manifest_overlay.json View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_renderer_manifest_overlay.json View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Ken Rockot(use gerrit already)
4 years, 1 month ago (2016-10-31 19:11:35 UTC) #3
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-10-31 19:41:41 UTC) #6
Tom Sepez
lgtm
4 years, 1 month ago (2016-10-31 20:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464693004/20001
4 years, 1 month ago (2016-10-31 20:20:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 20:55:00 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:58:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67c1db0e0886747ccb550b0df67394cfa5d5f312
Cr-Commit-Position: refs/heads/master@{#428804}

Powered by Google App Engine
This is Rietveld 408576698