Issue 24646002: Don't use start command when starting native messaging hosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24646002: Don't use start command when starting native messaging hosts. (Closed)

Created:
7 years, 2 months ago by Sergey Ulanov

Modified:
7 years, 2 months ago

Reviewers:
rvargas (doing something else), Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jschuh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't use start command when starting native messaging hosts. start calls 'cmd.exe /k' internally which keeps cmd running after host process exits. BUG=298304 R=mpcomplete@chromium.org, rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225300

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -18 lines)			Patch
	M	chrome/browser/extensions/api/messaging/native_process_launcher_win.cc	View	1 2 3	2 chunks	+1 line, -18 lines	0 comments	Download

Total messages: 6 (0 generated)

Sergey Ulanov

Ricardo, I'm sending this to you because Justin who reviewed this code originally is OOO.

7 years, 2 months ago (2013-09-25 19:17:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/24646002/4001

7 years, 2 months ago (2013-09-25 20:07:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/24646002/4001

7 years, 2 months ago (2013-09-25 21:59:55 UTC) #5

Sergey Ulanov

7 years, 2 months ago (2013-09-26 03:12:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r225300 (presubmit successful).