Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: chrome/test/ppapi/ppapi_browsertest.cc

Issue 2464593002: Fix disabling of failing test from r428558. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/test/test_timeouts.h" 9 #include "base/test/test_timeouts.h"
10 #include "base/win/windows_version.h" 10 #include "base/win/windows_version.h"
(...skipping 1281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1292 void SetUpCommandLine(base::CommandLine* command_line) override { 1292 void SetUpCommandLine(base::CommandLine* command_line) override {
1293 PackagedAppTest::SetUpCommandLine(command_line); 1293 PackagedAppTest::SetUpCommandLine(command_line);
1294 command_line->AppendSwitch(switches::kEnableNaClNonSfiMode); 1294 command_line->AppendSwitch(switches::kEnableNaClNonSfiMode);
1295 } 1295 }
1296 }; 1296 };
1297 1297
1298 // Load a packaged app, and wait for it to successfully post a "hello" message 1298 // Load a packaged app, and wait for it to successfully post a "hello" message
1299 // back. 1299 // back.
1300 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest, 1300 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest,
1301 MAYBE_PPAPI_NACL(SuccessfulLoad)) { 1301 MAYBE_PPAPI_NACL(SuccessfulLoad)) {
1302 #if defined(OS_MACOSX)
1303 if (base::mac::IsOS10_10() || base::mac::IsOS10_11())
1304 return; // Fails when swarmed. http://crbug.com/660582
1305 #endif
1302 RunTests("packaged_app"); 1306 RunTests("packaged_app");
1303 } 1307 }
1304 1308
1305 #if defined(OS_LINUX) 1309 #if defined(OS_LINUX)
1306 // http://crbug.com/579804 1310 // http://crbug.com/579804
1307 #define MAYBE_SuccessfulLoad DISABLED_SuccessfulLoad 1311 #define MAYBE_SuccessfulLoad DISABLED_SuccessfulLoad
1308 #else 1312 #else
1309 #define MAYBE_SuccessfulLoad MAYBE_PNACL_NONSFI(SuccessfulLoad) 1313 #define MAYBE_SuccessfulLoad MAYBE_PNACL_NONSFI(SuccessfulLoad)
1310 #endif 1314 #endif
1311 IN_PROC_BROWSER_TEST_F(NonSfiPackagedAppTest, MAYBE_SuccessfulLoad) { 1315 IN_PROC_BROWSER_TEST_F(NonSfiPackagedAppTest, MAYBE_SuccessfulLoad) {
1312 #if defined(OS_MACOSX)
1313 if (base::mac::IsOS10_10() || base::mac::IsOS10_11())
1314 return; // Fails when swarmed. http://crbug.com/660582
1315 #endif
1316 RunTests("packaged_app"); 1316 RunTests("packaged_app");
1317 } 1317 }
1318 1318
1319 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest, 1319 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest,
1320 MAYBE_PPAPI_NACL(MulticastPermissions)) { 1320 MAYBE_PPAPI_NACL(MulticastPermissions)) {
1321 RunTests("multicast_permissions"); 1321 RunTests("multicast_permissions");
1322 } 1322 }
1323 1323
1324 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest, 1324 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest,
1325 MAYBE_PPAPI_NACL(NoSocketPermissions)) { 1325 MAYBE_PPAPI_NACL(NoSocketPermissions)) {
1326 RunTests("no_socket_permissions"); 1326 RunTests("no_socket_permissions");
1327 } 1327 }
1328 1328
1329 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest, 1329 IN_PROC_BROWSER_TEST_F(NewlibPackagedAppTest,
1330 MAYBE_PPAPI_NACL(SocketPermissions)) { 1330 MAYBE_PPAPI_NACL(SocketPermissions)) {
1331 RunTests("socket_permissions"); 1331 RunTests("socket_permissions");
1332 } 1332 }
1333 1333
1334 #endif 1334 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698