Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2464463002: Revert of DevTools: clean up scripts folder (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
CC:
abarth-chromium, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: clean up scripts folder (patchset #7 id:120001 of https://codereview.chromium.org/2441163002/ ) Reason for revert: Causing compile error here: https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/27586 Original issue's description: > DevTools: clean up scripts folder > > - Use consistent snake_case naming for folders and files > - Move Python build scripts to scripts/build > - Add description in readme.md > - Rename js_build -> gulp > > BUG=none > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/c5c20f9f1b639a556c3aa87b1ebcd4ddc396649e > Cr-Commit-Position: refs/heads/master@{#428430} TBR=dgozman@chromium.org,dmazzoni@chromium.org,chenwilliam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/15558a64952e5ee2a4b23559afc9b8678efe664f Cr-Commit-Position: refs/heads/master@{#428480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5726 lines, -5714 lines) Patch
M chrome/browser/resources/chromeos/chromevox/run_jsbundler.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/PRESUBMIT.py View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py View 1 chunk +291 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/README.md View 1 chunk +3 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/build_debug_applications.py View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/build_release_applications.py View 1 chunk +0 lines, -228 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/code_generator_frontend.py View 1 chunk +0 lines, -291 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/devtools_file_hashes.py View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/generate_devtools_extension_api.py View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py View 1 chunk +0 lines, -246 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/generate_supported_css.py View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/modular_build.py View 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build/rjsmin.py View 1 chunk +0 lines, -296 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/build_debug_applications.py View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/build_release_applications.py View 1 chunk +228 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/closure/closure_runner/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/scripts/closure/closure_runner/build_compiler_runner_jar.py View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/closure/closure_runner/closure_runner.jar View Binary file 0 comments Download
D third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/Runner.java View 1 chunk +0 lines, -256 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 2 chunks +5 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/compiler-runner/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/compiler-runner/build_compiler_runner_jar.py View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/compiler-runner/closure-runner.jar View Binary file 0 comments Download
A third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/Runner.java View 1 chunk +259 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/convert_svg_images_to_png.py View 1 chunk +3 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/devtools_file_hashes.py View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/generate_devtools_extension_api.py View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py View 1 chunk +171 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py View 1 chunk +246 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/generate_supported_css.py View 1 chunk +72 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/gulp/concatenate_protocols.js View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/gulp/gulpfile.js View 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/gulp/package.json View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/gulp/release_mode_diff.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/gulp/test.sh View 1 chunk +0 lines, -15 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/js_build/ConcatenateProtocols.js View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/js_build/gulpfile.js View 1 chunk +149 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/js_build/package.json View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/js_build/release_mode_diff.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/js_build/test.sh View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/PRESUBMIT.py View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/build_jsdoc_validator_jar.py View 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/hashes View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/jsdoc-validator.jar View Binary file 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/run_tests.py View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/DoDidNodeVisitor.java View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/DoDidVisitorAdapter.java View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/JsDocValidator.java View 1 chunk +159 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java View 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingState.java View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java View 1 chunk +159 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/DisallowedGlobalPropertiesChecker.java View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionReceiverChecker.java View 1 chunk +300 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/MethodAnnotationChecker.java View 1 chunk +197 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ProtoFollowsExtendsChecker.java View 1 chunk +237 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/TypeRecord.java View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/document.js View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/function.js View 1 chunk +380 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/golden.dat View 1 chunk +424 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/proto.js View 1 chunk +137 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/jsdoc-validator/tests/this.js View 1 chunk +327 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/PRESUBMIT.py View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/build_jsdoc_validator_jar.py View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/hashes View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/jsdoc_validator.jar View Binary file 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/run_tests.py View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/DoDidNodeVisitor.java View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/DoDidVisitorAdapter.java View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/FileCheckerCallable.java View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/JsDocValidator.java View 1 chunk +0 lines, -157 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/ValidationCheck.java View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/ValidatorContext.java View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingState.java View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/DisallowedGlobalPropertiesChecker.java View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/FunctionReceiverChecker.java View 1 chunk +0 lines, -290 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/MethodAnnotationChecker.java View 1 chunk +0 lines, -192 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ProtoFollowsExtendsChecker.java View 1 chunk +0 lines, -238 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/TypeRecord.java View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/tests/document.js View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/tests/function.js View 1 chunk +0 lines, -380 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/tests/golden.dat View 1 chunk +0 lines, -424 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/tests/proto.js View 1 chunk +0 lines, -137 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/jsdoc_validator/tests/this.js View 1 chunk +0 lines, -327 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/modular_build.py View 1 chunk +190 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/optimize_png_images.py View 1 chunk +1 line, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/rjsmin.py View 1 chunk +296 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
xidachen
Created Revert of DevTools: clean up scripts folder
4 years, 1 month ago (2016-10-28 20:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464463002/1
4 years, 1 month ago (2016-10-28 20:36:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 20:39:12 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 20:42:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15558a64952e5ee2a4b23559afc9b8678efe664f
Cr-Commit-Position: refs/heads/master@{#428480}

Powered by Google App Engine
This is Rietveld 408576698