MD Settings: convert last .css file to style module

MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1
Cr-Commit-Position: refs/heads/master@{#430085}

[Dan Beam, 2016-11-03 01:31:06]

Description was changed from

==========
MD Settings: remove last .css file and inline into HTML

R=dpapad@chromium.org
BUG=600588
==========

to

==========
MD Settings: remove last .css file and inline into HTML

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-03 01:34:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 01:34:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:50:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Dan Beam, 2016-11-03 04:01:56]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 04:02:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 04:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 04:50:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2016-11-03 17:49:09]

https://codereview.chromium.org/2464393003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_entry.css
(left):

https://codereview.chromium.org/2464393003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_entry.css:1:
/* Copyright (c) 2015 The Chromium Authors. All rights reserved.
This file was being used by both search_engine_entry.html and omnibox_entry.html
(which is also why it was still left as a separate file. This CL merges it into
search_engine_entry.html, and now omnibox_entry.html refers to a non existent
file.

[Dan Beam, 2016-11-04 20:54:57]

https://codereview.chromium.org/2464393003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_entry.css
(left):

https://codereview.chromium.org/2464393003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_entry.css:1:
/* Copyright (c) 2015 The Chromium Authors. All rights reserved.
On 2016/11/03 17:49:09, dpapad wrote:
> This file was being used by both search_engine_entry.html and
omnibox_entry.html
> (which is also why it was still left as a separate file. This CL merges it
into
> search_engine_entry.html, and now omnibox_entry.html refers to a non existent
> file.

i swear i grepped for it.  oh well, made a style module.  thanks for catching.

[Dan Beam, 2016-11-04 20:55:44]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2016-11-04 20:56:03]

Description was changed from

==========
MD Settings: remove last .css file and inline into HTML

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-04 20:56:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 20:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:59:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dpapad, 2016-11-04 21:05:48]

LGTM. Probably need to resolve some conflicts though.

https://codereview.chromium.org/2464393003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html
(right):

https://codereview.chromium.org/2464393003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html:1:
<dom-module id="search-engine-entry">
Just noticing this, even though it is all over the codebase. We don't use
license header for HTML files, intentional?

[Dan Beam, 2016-11-04 21:20:14]

https://codereview.chromium.org/2464393003/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html
(right):

https://codereview.chromium.org/2464393003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html:1:
<dom-module id="search-engine-entry">
On 2016/11/04 21:05:48, dpapad wrote:
> Just noticing this, even though it is all over the codebase. We don't use
> license header for HTML files, intentional?

semi-intentional.  for a while HTML wasn't considered "code".

we should probably start eventually.

[Dan Beam, 2016-11-04 22:46:57]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-11-04 22:46:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2464393003/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2016-11-04 22:47:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:28:09]

Description was changed from

==========
MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-05 00:28:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-05 00:30:28]

Description was changed from

==========
MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG=600588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1
Cr-Commit-Position: refs/heads/master@{#430085}
==========

[commit-bot: I haz the power, 2016-11-05 00:30:29]

Patchset 4 (id:??) landed as
https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1
Cr-Commit-Position: refs/heads/master@{#430085}