Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2464393002: [heap] Invoke incremental marking step before allocation. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, ericrk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Invoke incremental marking step before allocation. This ensures that the newly allocated object immediatly precedes the linear allocation area, which is needed for allocation folding. For more info see: https://bugs.chromium.org/p/chromium/issues/detail?id=659165#c13 BUG=chromium:659165 Committed: https://crrev.com/bb24b91f1533decd1b586ef366efa10f6e5e4d75 Cr-Commit-Position: refs/heads/master@{#40704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -64 lines) Patch
M src/heap/incremental-marking.h View 4 chunks +1 line, -18 lines 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +27 lines, -46 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ulan
ptal, alternative solution for the same problem as cl 2469273002
4 years, 1 month ago (2016-11-02 11:50:31 UTC) #2
Michael Lippautz
lgtm on the duct tape approach like the other one better though
4 years, 1 month ago (2016-11-02 12:38:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464393002/1
4 years, 1 month ago (2016-11-02 13:42:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 14:13:34 UTC) #6
Michael Achenbach
The roll bisect job https://codereview.chromium.org/2466983004/ points to this CL, though the gpu test seems to ...
4 years, 1 month ago (2016-11-03 09:21:26 UTC) #7
ulan
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2472043002/ by ulan@chromium.org. ...
4 years, 1 month ago (2016-11-03 09:56:28 UTC) #8
Michael Achenbach
This probably also causes a timeout on GPU FYI. CC sheriff. https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/44812 Started shortly after ...
4 years, 1 month ago (2016-11-03 15:58:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb24b91f1533decd1b586ef366efa10f6e5e4d75
Cr-Commit-Position: refs/heads/master@{#40704}

Powered by Google App Engine
This is Rietveld 408576698