Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodecUserDefinedTest.cpp

Issue 2464373006: Fix vector resize logic when encoding non-BMP chars to x-user-defined (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/text/TextCodecUserDefined.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/TextCodecUserDefinedTest.cpp
diff --git a/third_party/WebKit/Source/wtf/text/TextCodecLatin1Test.cpp b/third_party/WebKit/Source/wtf/text/TextCodecUserDefinedTest.cpp
similarity index 71%
copy from third_party/WebKit/Source/wtf/text/TextCodecLatin1Test.cpp
copy to third_party/WebKit/Source/wtf/text/TextCodecUserDefinedTest.cpp
index 71fb8d15b481e7334abd122a90d1dfbb237591df..9442ab5a21092da40f44b700577fbf680e6e0c8e 100644
--- a/third_party/WebKit/Source/wtf/text/TextCodecLatin1Test.cpp
+++ b/third_party/WebKit/Source/wtf/text/TextCodecUserDefinedTest.cpp
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "wtf/text/TextCodecLatin1.h"
+#include "wtf/text/TextCodecUserDefined.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "wtf/text/CString.h"
@@ -11,8 +11,8 @@
#include "wtf/text/TextEncodingRegistry.h"
#include <memory>
-TEST(TextCodecLatin1Test, QuestionMarksAndSurrogates) {
- WTF::TextEncoding encoding("windows-1252");
+TEST(TextCodecUserDefinedTest, QuestionMarksAndSurrogates) {
+ WTF::TextEncoding encoding("x-user-defined");
std::unique_ptr<WTF::TextCodec> codec(newTextCodec(encoding));
{
@@ -20,7 +20,7 @@ TEST(TextCodecLatin1Test, QuestionMarksAndSurrogates) {
size_t testCaseSize = WTF_ARRAY_LENGTH(testCase);
CString result = codec->encode(testCase, testCaseSize,
WTF::QuestionMarksForUnencodables);
- EXPECT_STREQ("\xd1\x16?", result.data());
+ EXPECT_STREQ("?\x16?", result.data());
}
{
const UChar testCase[] = {0xd9f0, 0xdcd9};
@@ -36,4 +36,11 @@ TEST(TextCodecLatin1Test, QuestionMarksAndSurrogates) {
WTF::QuestionMarksForUnencodables);
EXPECT_STREQ("??", result.data());
}
+ {
+ const UChar testCase[] = {0x0041, 0xd9f0, 0xdcd9, 0xf7c1, 0xd9f0, 0xdcd9};
+ size_t testCaseSize = WTF_ARRAY_LENGTH(testCase);
+ CString result = codec->encode(testCase, testCaseSize,
+ WTF::QuestionMarksForUnencodables);
+ EXPECT_STREQ("A?\xC1?", result.data());
+ }
}
« no previous file with comments | « third_party/WebKit/Source/wtf/text/TextCodecUserDefined.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698