Support different Google attestation (Privacy CA) servers.

Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)

Committed: https://crrev.com/0f864585a479d0c103a6d5b9ac8b3347385a093e
Cr-Commit-Position: refs/heads/master@{#429205}

[The one and only Dr. Crash, 2016-11-02 03:11:42]

The CQ bit was checked by drcrash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 03:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[The one and only Dr. Crash, 2016-11-02 03:12:15]

Description was changed from

==========
Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)
==========

to

==========
Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)
==========

[The one and only Dr. Crash, 2016-11-02 03:12:16]

drcrash@chromium.org changed reviewers:
+ dkrahn@chromium.org

[The one and only Dr. Crash, 2016-11-02 03:15:15]

Darren, please review this change to fix the unit tests in my previous CL
(2448213007) which was reverted for leaking memory in tests. It turns out that
sending a response in tests is critical to clean up memory. I reran the tests
with ASAN on this.

I also took this opportunity to check the PCA URL in the first two tests,
validating that the default PCA is indeed used even if --attestation-server is
not passed.

Thanks for the review, my apologies for the churn!

[Darren Krahn, 2016-11-02 03:18:40]

On 2016/11/02 03:15:15, The one and only Dr. Crash wrote:
> Darren, please review this change to fix the unit tests in my previous CL
> (2448213007) which was reverted for leaking memory in tests. It turns out that
> sending a response in tests is critical to clean up memory. I reran the tests
> with ASAN on this.
> 
> I also took this opportunity to check the PCA URL in the first two tests,
> validating that the default PCA is indeed used even if --attestation-server is
> not passed.
> 
> Thanks for the review, my apologies for the churn!

lgtm

[commit-bot: I haz the power, 2016-11-02 03:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 03:47:59]

Dry run: This issue passed the CQ dry run.

[The one and only Dr. Crash, 2016-11-02 04:00:31]

The CQ bit was checked by drcrash@chromium.org

[commit-bot: I haz the power, 2016-11-02 04:00:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 04:05:48]

Description was changed from

==========
Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)
==========

to

==========
Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)
==========

[commit-bot: I haz the power, 2016-11-02 04:05:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 04:09:31]

Description was changed from

==========
Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)
==========

to

==========
Support different Google attestation (Privacy CA) servers.

Add a --attestation-server flag that allows to pick the default or
the test server, and pass the appropriate value to cryptohomed
for operations involving requests sent to the attestation servers.
Also use the appropriate endpoints for the various servers when
sending requests.

BUG=660260
TEST=unit tests (with asan enabled)

Committed: https://crrev.com/0f864585a479d0c103a6d5b9ac8b3347385a093e
Cr-Commit-Position: refs/heads/master@{#429205}
==========

[commit-bot: I haz the power, 2016-11-02 04:09:32]

Patchset 2 (id:??) landed as
https://crrev.com/0f864585a479d0c103a6d5b9ac8b3347385a093e
Cr-Commit-Position: refs/heads/master@{#429205}