Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/browser/media/webrtc_browsertest.cc

Issue 246433006: Change MediaStreamVideoSource to output different resolutions to different tracks depending on the … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/webrtc_browsertest.cc
diff --git a/content/browser/media/webrtc_browsertest.cc b/content/browser/media/webrtc_browsertest.cc
index 69fd5c0578d9cd24e5488d000de055f8a7f4fcc3..13414f60725ab66a3378756637e0715f123405f0 100644
--- a/content/browser/media/webrtc_browsertest.cc
+++ b/content/browser/media/webrtc_browsertest.cc
@@ -105,6 +105,22 @@ IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, CanSetupVideoCallWith1To1AspecRatio) {
MakeTypicalPeerConnectionCall(javascript);
}
+IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest,
+ CanSetupVideoCallWith16To9AspecRatio) {
+ const std::string javascript =
+ "callAndExpectResolution({video: {mandatory: {minWidth: 640,"
+ " maxWidth: 640, minAspectRatio: 1.7777}}}, 640, 360);";
+ MakeTypicalPeerConnectionCall(javascript);
+}
+
+IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest,
+ CanSetupVideoCallWith4To3AspecRatio) {
+ const std::string javascript =
+ "callAndExpectResolution({video: {mandatory: {minWidth: 960,"
+ "maxAspectRatio: 1.333}}}, 960, 720);";
+ MakeTypicalPeerConnectionCall(javascript);
mcasas 2014/05/09 07:46:24 ultra-nit: Three decimals here and four for 16:9,
perkj_chrome 2014/05/13 11:05:56 done
+}
+
#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
// Timing out on ARM linux, see http://crbug.com/240376
#define MAYBE_CanSetupAudioAndVideoCall DISABLED_CanSetupAudioAndVideoCall

Powered by Google App Engine
This is Rietveld 408576698