Change MediaStreamVideoSource to output different resolutions to different tracks depending on the …

content/browser/media/webrtc_getusermedia_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/debug/trace_event_impl.h"
 #include "base/json/json_reader.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/trace_event_analyzer.h"
 #include "base/values.h"
@@ skipping 410 matching lines @@
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
   GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(
       "twoGetUserMediaAndStop({video: true, audio: true});");
 }
 
 IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
+                       TwoGetUserMediaWithEqualConstraints) {
+  ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+
+  GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
+  NavigateToURL(shell(), url);
+
+  std::string constraints1 = "{video: true, audio: true}";

[tommi (sloooow) - chröme, 2014/05/09 11:16:13]

nit: why not just |constraints|?  (why do you need to string variables to hold
the same value?)

[perkj_chrome, 2014/05/13 11:05:56]

Refactored.

+  std::string constraints2 = "{video: true, audio: true}";
+
+  std::string command = "twoGetUserMedia(" + constraints1 + ',' +
+      constraints2 + ')';
+
+  EXPECT_EQ("w=640:h=480-w=640:h=480",
+            ExecuteJavascriptAndReturnResult(command));
+}
+
+IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
+                       TwoGetUserMediaWithSecondVideoCropped) {
+  ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+
+  GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
+  NavigateToURL(shell(), url);
+
+  std::string constraints1 = "{video: true}";
+  std::string constraints2 = "{video: {mandatory: {maxHeight: 360}}}";
+
+  std::string command = "twoGetUserMedia(" + constraints1 + ',' +
+      constraints2 + ')';
+
+  EXPECT_EQ("w=640:h=480-w=640:h=360",
+            ExecuteJavascriptAndReturnResult(command));
+}
+
+IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
+                       TwoGetUserMediaWithFirstHdSecondVga) {
+  ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+
+  GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
+  NavigateToURL(shell(), url);
+
+  std::string constraints1 =
+      "{video: {mandatory: {minWidth:1280 , minHeight: 720}}}";
+  std::string constraints2 =
+      "{video: {mandatory: {maxWidth:640 , maxHeight: 480}}}";
+
+  std::string command = "twoGetUserMedia(" + constraints1 + ',' +

[tommi (sloooow) - chröme, 2014/05/09 11:16:13]

suggestion: make a method, std::string TwoGetUserMedia(const std::string&
constraints1, const std::string& constraints2);

Then have that method do the string concatenation and return
ExecuteJavascriptAndReturnResult(command).

That way you keep the construction of the javascript in one place and improve
readability of the tests.

[perkj_chrome, 2014/05/13 11:05:56]

I went for Miguels request below.

+      constraints2 + ')';
+
+  EXPECT_EQ("w=1280:h=720-w=640:h=480",
+            ExecuteJavascriptAndReturnResult(command));
+}

[mcasas, 2014/05/09 07:46:24]

These three tests share code. What about a method
with params (constraints1, constraints2, expected_result)?

[perkj_chrome, 2014/05/13 11:05:56]

Done.

+
+IN_PROC_BROWSER_TEST_P(WebRtcGetUserMediaBrowserTest,
                        GetUserMediaWithTooHighVideoConstraintsValues) {
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
   GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
 
   int large_value = 99999;
   std::string call = GenerateGetUserMediaCall(kGetUserMediaAndExpectFailure,
                                               large_value,
                                               large_value,
                                               large_value,
@@ skipping 112 matching lines @@
     {640, 640, 360, 360, 10, 30},
     {640, 640, 480, 480, 10, 30},
     {960, 960, 720, 720, 10, 30},
     {1280, 1280, 720, 720, 10, 30}};
 
 INSTANTIATE_TEST_CASE_P(UserMedia,
                         WebRtcConstraintsBrowserTest,
                         testing::ValuesIn(kAllUserMediaSizes));
 
 }  // namespace content