Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Issue 246433005: gclient: Only _DeleteOrMove if the destination directory is non-empty (Closed)

Created:
6 years, 8 months ago by borenet
Modified:
6 years, 8 months ago
Reviewers:
phajdan, iannucci, ghost stip (do not use)
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

gclient: Only _DeleteOrMove if the destination directory is non-empty BUG=364601 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M gclient_scm.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/gclient_scm_test.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
borenet
6 years, 8 months ago (2014-04-22 13:16:35 UTC) #1
iannucci
lgtm
6 years, 8 months ago (2014-04-22 17:40:03 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 8 months ago (2014-04-22 17:40:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/246433005/1
6 years, 8 months ago (2014-04-22 17:40:57 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 17:42:55 UTC) #5
Message was sent while issue was closed.
Change committed as 265298

Powered by Google App Engine
This is Rietveld 408576698