[Chromoting] GetHostAttributes with tests

remoting/host/directx_attributes.cc

Index: remoting/host/directx_attributes.cc
diff --git a/remoting/host/directx_attributes.cc b/remoting/host/directx_attributes.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b213609f5c00ca7c617131053d624bec35799744
--- /dev/null
+++ b/remoting/host/directx_attributes.cc
@@ -0,0 +1,26 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.

[Sergey Ulanov, 2016/11/03 22:17:42]

Do we really need one file per attribute, instead of a single file listing all
attributes for each platform?

[Hzj_jie, 2016/11/05 05:29:28]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/directx_attributes.h"
+
+#if defined(OS_WIN)

[Sergey Ulanov, 2016/11/03 22:17:42]

I think you need to include build/build_config.h to get OS_WIN

[Hzj_jie, 2016/11/05 05:29:28]

Done.

+#include "remoting/host/host_attributes.h"
+#include "third_party/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h"
+
+namespace remoting {
+
+void RegisterDirectxAttributes() {
+  host_attributes().Register("DirectX-Capturer",

[Sergey Ulanov, 2016/11/03 22:15:34]

What is host_attributes() and where is it defined? I don't see it in this
patchset.

[Hzj_jie, 2016/11/05 05:29:28]

I forgot to change this file.

+                             &ScreenCapturerWinDirectx::IsSupported);
+  // TODO(zijiehe): Add minimum and maximum DirectX version supported on the
+  // system. Blocked by change https://codereview.chromium.org/2468083002/.
+}
+
+}  // namespace remoting
+#else
+namespace remoting {
+// Do nothing on other platforms.
+void RegisterDirectxAttributes() {}
+}  // namespace remoting
+#endif