Chromium Code Reviews Chromium Code Reviews
Issue 2464253002:
Fix flaky test paint/invalidation/background-resize-height.html (Closed)
| Index: third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html |
| diff --git a/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html b/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html |
| index 88f87468ce3b7edf6502f5398fc982613794462b..204f674b23a5c440755f7d23b9d176b5d665573d 100644 |
| --- a/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html |
| +++ b/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html |
| @@ -1,9 +1,19 @@ |
| <!DOCTYPE html> |
| <script src="resources/text-based-repaint.js" type="text/javascript"></script> |
| <script> |
| +window.testIsAsync = true; |
| +function doTest() { |
| + document.getElementById('container').style.height = '550px'; |
| + finishRepaintTest(); |
| +} |
| function repaintTest() |
| { |
| - document.getElementById('container').style.height = '550px'; |
| + if (window.testRunner) { |
| + // This ensures finish of image decoding before running the test. |
| + testRunner.capturePixelsAsyncThen(doTest); |
| + } else { |
| + doTest(); |
| + } |
| } |
| window.onload = runRepaintAndPixelTest; |
| </script> |
| @@ -52,7 +62,7 @@ window.onload = runRepaintAndPixelTest; |
| left: 300px; |
| } |
| .center { |
| - background-position: center; |
| + background-position: center; |
| left: 350px; |
| } |
| .no-repeat { |
| @@ -81,9 +91,11 @@ window.onload = runRepaintAndPixelTest; |
| <div class="test image repeat-space"></div> |
| <div class="test image repeat-round"></div> |
| <div class="test generated"></div> |
| - <div class="test generated cover"></div> |
| - <div class="test generated contain"></div> |
| + <div class="test generated size-cover"></div> |
| + <div class="test generated size-contain"></div> |
| + <!-- This produces invisible pixel difference. |
|
chrishtr
2016/11/01 23:20:20
Just delete this div then?
Xianzhu
2016/11/01 23:59:19
Done locally. Will upload after rebaseline-cl.
|
| <div class="test generated fixed-height"></div> |
| + --> |
| <div class="test generated percent-height"></div> |
| <div class="test generated top"></div> |
| <div class="test generated bottom"></div> |
