Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: base/threading/thread.h

Issue 2464233002: Experiment with redirecting all BrowserThreads (but UI/IO) to TaskScheduler (Closed)
Patch Set: Rely on Thread::using_external_message_loop_ instead of hard-coding BrowserThread::UI Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.h » ('j') | content/browser/browser_main_loop.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread.h
diff --git a/base/threading/thread.h b/base/threading/thread.h
index b8136db8829c172b1a791b372291af4bfffb7ec2..e63112cbbeea6684f4d118db01a2fe9117ecfa6d 100644
--- a/base/threading/thread.h
+++ b/base/threading/thread.h
@@ -244,6 +244,11 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
// Bind this Thread to an existing MessageLoop instead of starting a new one.
void SetMessageLoop(MessageLoop* message_loop);
+ // True only if |message_loop_| was externally provided by |SetMessageLoop()|
+ // in which case this Thread has no underlying |thread_| and should merely
+ // drop |message_loop_| on Stop().
+ bool using_external_message_loop_ = false;
Avi (use Gerrit) 2016/11/08 16:16:15 Data members that are protected are a violation of
gab 2016/11/08 20:40:44 Done.
+
private:
#if defined(OS_WIN)
enum ComStatus {
@@ -291,11 +296,6 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
MessageLoop* message_loop_ = nullptr;
RunLoop* run_loop_ = nullptr;
- // True only if |message_loop_| was externally provided by |SetMessageLoop()|
- // in which case this Thread has no underlying |thread_| and should merely
- // drop |message_loop_| on Stop().
- bool using_external_message_loop_ = false;
-
// Stores Options::timer_slack_ until the message loop has been bound to
// a thread.
TimerSlack message_loop_timer_slack_ = TIMER_SLACK_NONE;
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.h » ('j') | content/browser/browser_main_loop.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698