extensions/common/features/base_feature_provider.h - Issue 246423002: Split feature definitions into extensions and chrome features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider.h

Issue 246423002: Split feature definitions into extensions and chrome features. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: repack2 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/base_feature_provider.h

diff --git a/extensions/common/features/base_feature_provider.h b/extensions/common/features/base_feature_provider.h

index 4defdc2f4514c686ff6023e399e33a884fa2e054..acb8df3bdc61ee87213d2c64506e2e2828077841 100644

--- a/extensions/common/features/base_feature_provider.h

+++ b/extensions/common/features/base_feature_provider.h

@@ -27,9 +27,6 @@ class BaseFeatureProvider : public FeatureProvider {

FeatureFactory factory);

virtual ~BaseFeatureProvider();

- // Gets a feature provider for a specific feature type, like "permission".

- static FeatureProvider* GetByName(const std::string& name);

// Gets the feature |feature_name|, if it exists.

virtual Feature* GetFeature(const std::string& feature_name) const OVERRIDE;

virtual Feature* GetParent(Feature* feature) const OVERRIDE;