Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4623)

Unified Diff: chrome/common/extensions/chrome_extensions_client.h

Issue 246423002: Split feature definitions into extensions and chrome features. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: repack2 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/chrome_extensions_client.h
diff --git a/chrome/common/extensions/chrome_extensions_client.h b/chrome/common/extensions/chrome_extensions_client.h
index 49f3564fbe33236bb28353eca2903c467f3f05c7..d11c26f30905f24901713a370846a379e8128bb8 100644
--- a/chrome/common/extensions/chrome_extensions_client.h
+++ b/chrome/common/extensions/chrome_extensions_client.h
@@ -26,8 +26,8 @@ class ChromeExtensionsClient : public ExtensionsClient {
virtual const PermissionsProvider& GetPermissionsProvider() const OVERRIDE;
virtual const PermissionMessageProvider& GetPermissionMessageProvider() const
OVERRIDE;
- virtual FeatureProvider* GetFeatureProviderByName(const std::string& name)
- const OVERRIDE;
+ virtual scoped_ptr<FeatureProvider> CreateFeatureProvider(
+ const std::string& name) const OVERRIDE;
virtual void FilterHostPermissions(
const URLPatternSet& hosts,
URLPatternSet* new_hosts,
@@ -43,7 +43,6 @@ class ChromeExtensionsClient : public ExtensionsClient {
virtual bool IsAPISchemaGenerated(const std::string& name) const OVERRIDE;
virtual base::StringPiece GetAPISchema(const std::string& name) const
OVERRIDE;
- virtual void AddExtraFeatureFilters(SimpleFeature* feature) const OVERRIDE;
virtual bool ShouldSuppressFatalErrors() const OVERRIDE;
// Get the LazyInstance for ChromeExtensionsClient.
« no previous file with comments | « chrome/common/extensions/api/_permission_features.json ('k') | chrome/common/extensions/chrome_extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698