Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2464163004: [RemotePlayback] Implement 'connecting' state (Closed)

Created:
4 years, 1 month ago by whywhat
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, nessy, Srirama, vcarbune.chromium, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[RemotePlayback] Implement 'connecting' state BUG=660408 TEST=manual Committed: https://crrev.com/fee74d8fdab4a7bae779fac126a910827dfce5bf Cr-Commit-Position: refs/heads/master@{#430430}

Patch Set 1 #

Patch Set 2 : Fixed mocks #

Total comments: 1

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteController.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_bridge.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_bridge.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_manager.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_manager.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/renderer_media_player_interface.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayerClient.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (21 generated)
whywhat
PTaL hubbe: media/blink mlamouri: remote/ WebKit/
4 years, 1 month ago (2016-11-02 22:51:20 UTC) #2
whywhat
Fixed mocks
4 years, 1 month ago (2016-11-03 00:06:04 UTC) #7
mlamouri (slow - plz ping)
lgtm but as for https://codereview.chromium.org/2468303002, we need tests for this https://codereview.chromium.org/2464163004/diff/20001/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/2464163004/diff/20001/content/renderer/media/android/webmediaplayer_android.cc#newcode882 ...
4 years, 1 month ago (2016-11-03 16:17:48 UTC) #12
whywhat
hubbe, please review *media* +dcheng for media_player_messages_android.h
4 years, 1 month ago (2016-11-04 15:32:07 UTC) #14
whywhat
Rebased
4 years, 1 month ago (2016-11-04 16:45:41 UTC) #15
dcheng
ipc lgtm
4 years, 1 month ago (2016-11-04 17:14:17 UTC) #16
hubbe
media lgtm
4 years, 1 month ago (2016-11-05 03:33:14 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464163004/40001
4 years, 1 month ago (2016-11-06 03:16:29 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/175251)
4 years, 1 month ago (2016-11-06 04:32:28 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464163004/40001
4 years, 1 month ago (2016-11-07 21:26:42 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/101193)
4 years, 1 month ago (2016-11-07 22:08:32 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464163004/40001
4 years, 1 month ago (2016-11-07 23:52:55 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 00:00:42 UTC) #33
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 00:10:16 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fee74d8fdab4a7bae779fac126a910827dfce5bf
Cr-Commit-Position: refs/heads/master@{#430430}

Powered by Google App Engine
This is Rietveld 408576698