Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2464143005: Switch chromium.perf Android Nexus5X over to chromium recipe (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Switch chromium.perf Android Nexus5X over to chromium recipe This CL switches the Android Nexus5X builder over to the chromium recipe. Ideally if this works, we can switch the rest of the builders over immediatelly after. BUG=639530 Committed: https://chromium.googlesource.com/chromium/tools/build/+/3c85a1ffc8f2c1051c0e8b786df5e5d2d12e1e68

Patch Set 1 #

Patch Set 2 : Change to Android One. #

Patch Set 3 : Whoops, mis-read message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M masters/master.chromium.perf/master.cfg View 2 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
martiniss
PTAL Do you have a preference for which builder I should convert first? There's the ...
4 years, 1 month ago (2016-11-02 23:04:09 UTC) #2
sullivan
lgtm On 2016/11/02 23:04:09, martiniss wrote: > PTAL > > Do you have a preference ...
4 years, 1 month ago (2016-11-03 14:11:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464143005/40001
4 years, 1 month ago (2016-11-04 00:30:48 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/3c85a1ffc8f2c1051c0e8b786df5e5d2d12e1e68
4 years, 1 month ago (2016-11-04 00:40:42 UTC) #8
martiniss
4 years, 1 month ago (2016-11-04 03:45:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2475193002/ by martiniss@chromium.org.

The reason for reverting is: Weird error, caused by bad properties??.

Powered by Google App Engine
This is Rietveld 408576698