cc : Reland Move screen space scale factor to root transform node

cc : Reland Move screen space scale factor to root transform node

This CL computes the screen space scale factor which is
combined form scale factors of device transform, device
scale factor and page scale factor(if required), and stores
it on the root transform node as its surface contents scale.
This also implicitly fixes a clipping bug.
TransformTree::ComputeTransforms(a, b) should return the
transform between a and b without the surface contents
scale. But, since screen space scale was baked into the
local transform of the contents root node (before this CL),
ComputeTransform(a, root) was having the scale baked in.
(and this caused the bug)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2408243002
Cr-Commit-Position: refs/heads/master@{#427366}
(cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)

Committed: https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b25318d43700fc

patch from issue 2452023003 at patchset 1 (http://crrev.com/2452023003#ps1)

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644582

[jaydasika, 2016-11-03 18:32:18]

Patchset #2 (id:20001) has been deleted

[jaydasika, 2016-11-03 18:35:05]

Description was changed from

==========
cc : Reland Move screen space scale factor to root transform node

This CL computes the screen space scale factor which is
combined form scale factors of device transform, device
scale factor and page scale factor(if required), and stores
it on the root transform node as its surface contents scale.
This also implicitly fixes a clipping bug.
TransformTree::ComputeTransforms(a, b) should return the
transform between a and b without the surface contents
scale. But, since screen space scale was baked into the
local transform of the contents root node (before this CL),
ComputeTransform(a, root) was having the scale baked in.
(and this caused the bug)

BUG=651584
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2408243002
Cr-Commit-Position: refs/heads/master@{#427366}
(cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)

Committed:
https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b2...

patch from issue 2452023003 at patchset 1 (http://crrev.com/2452023003#ps1)
==========

to

==========
cc : Reland Move screen space scale factor to root transform node

This CL computes the screen space scale factor which is
combined form scale factors of device transform, device
scale factor and page scale factor(if required), and stores
it on the root transform node as its surface contents scale.
This also implicitly fixes a clipping bug.
TransformTree::ComputeTransforms(a, b) should return the
transform between a and b without the surface contents
scale. But, since screen space scale was baked into the
local transform of the contents root node (before this CL),
ComputeTransform(a, root) was having the scale baked in.
(and this caused the bug)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2408243002
Cr-Commit-Position: refs/heads/master@{#427366}
(cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)

Committed:
https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b2...

patch from issue 2452023003 at patchset 1 (http://crrev.com/2452023003#ps1)

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644582
==========

[jaydasika, 2016-11-03 18:40:27]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-11-03 18:40:27]

This is the CL I want to land on M55 after the merge request is approved. It is
different from what landed on ToT because there is no surface contents scale on
transform tree on ToT but M55 still uses it. So, I took the patch which I landed
and reverted on M55, and appended the changes from the relanded patch on top of
it.
PTAL, I will wait for a review before landing this

[jaydasika, 2016-11-03 22:15:46]

On 2016/11/03 18:40:27, jaydasika wrote:
> This is the CL I want to land on M55 after the merge request is approved. It
is
> different from what landed on ToT because there is no surface contents scale
on
> transform tree on ToT but M55 still uses it. So, I took the patch which I
landed
> and reverted on M55, and appended the changes from the relanded patch on top
of
> it.
> PTAL, I will wait for a review before landing this

received merge approval, so this is ready for review.

[jaydasika, 2016-11-04 18:49:55]

On 2016/11/03 22:15:46, jaydasika wrote:
> On 2016/11/03 18:40:27, jaydasika wrote:
> > This is the CL I want to land on M55 after the merge request is approved. It
> is
> > different from what landed on ToT because there is no surface contents scale
> on
> > transform tree on ToT but M55 still uses it. So, I took the patch which I
> landed
> > and reverted on M55, and appended the changes from the relanded patch on top
> of
> > it.
> > PTAL, I will wait for a review before landing this
> 
> received merge approval, so this is ready for review.

ping. I was asked to merge this before 4pm PST today.

[weiliangc, 2016-11-04 18:55:32]

LGTM

[jaydasika, 2016-11-04 18:56:24]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:56:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:05:23]

Description was changed from

==========
cc : Reland Move screen space scale factor to root transform node

This CL computes the screen space scale factor which is
combined form scale factors of device transform, device
scale factor and page scale factor(if required), and stores
it on the root transform node as its surface contents scale.
This also implicitly fixes a clipping bug.
TransformTree::ComputeTransforms(a, b) should return the
transform between a and b without the surface contents
scale. But, since screen space scale was baked into the
local transform of the contents root node (before this CL),
ComputeTransform(a, root) was having the scale baked in.
(and this caused the bug)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2408243002
Cr-Commit-Position: refs/heads/master@{#427366}
(cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)

Committed:
https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b2...

patch from issue 2452023003 at patchset 1 (http://crrev.com/2452023003#ps1)

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644582
==========

to

==========
cc : Reland Move screen space scale factor to root transform node

This CL computes the screen space scale factor which is
combined form scale factors of device transform, device
scale factor and page scale factor(if required), and stores
it on the root transform node as its surface contents scale.
This also implicitly fixes a clipping bug.
TransformTree::ComputeTransforms(a, b) should return the
transform between a and b without the surface contents
scale. But, since screen space scale was baked into the
local transform of the contents root node (before this CL),
ComputeTransform(a, root) was having the scale baked in.
(and this caused the bug)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2408243002
Cr-Commit-Position: refs/heads/master@{#427366}
(cherry picked from commit 61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6)

Committed:
https://chromium.googlesource.com/chromium/src/+/b96a29859b70eea11eacefef82b2...

patch from issue 2452023003 at patchset 1 (http://crrev.com/2452023003#ps1)

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644582
==========

[commit-bot: I haz the power, 2016-11-04 19:05:24]

Committed patchset #2 (id:40001)