Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: pkg/compiler/lib/src/js_backend/backend_helpers.dart

Issue 2464103002: Introduce ClassLike, MemberLike, FieldLike and FunctionLike (Closed)
Patch Set: Updated cf. comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend_helpers.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend_helpers.dart b/pkg/compiler/lib/src/js_backend/backend_helpers.dart
index 165307fda23b0af2eb750072e4ba9d51b66d3faa..eb347c3623635574227fc91964d59aa32f08b16f 100644
--- a/pkg/compiler/lib/src/js_backend/backend_helpers.dart
+++ b/pkg/compiler/lib/src/js_backend/backend_helpers.dart
@@ -16,8 +16,10 @@ import '../elements/elements.dart'
ConstructorElement,
Element,
EnumClassElement,
+ FieldElement,
FunctionElement,
LibraryElement,
+ MemberElement,
MethodElement,
PublicName;
import '../library_loader.dart' show LoadedLibraries;
@@ -105,11 +107,11 @@ class BackendHelpers {
ClassElement jsUInt32Class;
ClassElement jsUInt31Class;
- Element jsIndexableLength;
+ MemberElement jsIndexableLength;
Element jsArrayTypedConstructor;
- Element jsArrayRemoveLast;
- Element jsArrayAdd;
- Element jsStringSplit;
+ MethodElement jsArrayRemoveLast;
+ MethodElement jsArrayAdd;
+ MethodElement jsStringSplit;
Element jsStringToString;
Element jsStringOperatorAdd;
Element objectEquals;
@@ -371,10 +373,14 @@ class BackendHelpers {
}
jsIndexableClass.ensureResolved(resolution);
- jsIndexableLength = compiler.lookupElementIn(jsIndexableClass, 'length');
- if (jsIndexableLength != null && jsIndexableLength.isAbstractField) {
- AbstractFieldElement element = jsIndexableLength;
+ Element jsIndexableLengthElement =
+ compiler.lookupElementIn(jsIndexableClass, 'length');
+ if (jsIndexableLengthElement != null &&
+ jsIndexableLengthElement.isAbstractField) {
+ AbstractFieldElement element = jsIndexableLengthElement;
jsIndexableLength = element.getter;
+ } else {
+ jsIndexableLength = jsIndexableLengthElement;
}
jsArrayClass.ensureResolved(resolution);
@@ -402,7 +408,7 @@ class BackendHelpers {
return findHelper('mainHasTooManyParameters');
}
- Element get loadLibraryWrapper {
+ MethodElement get loadLibraryWrapper {
return findHelper("_loadLibraryWrapper");
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698