Introduce ClassLike, MemberLike, FieldLike and FunctionLike

Introduce ClassLike, MemberLike, FieldLike and FunctionLike

... to prepare for replacing the current element model with kernel based elements (for the resolution world) and Dart-in-JS elements (for the codegen world).

New classes in elements.dart.
Main changes in nodes.dart.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/db14062bab29da28762ed874ee3a29234ee3521a

[Johnni Winther, 2016-11-01 15:30:41]

Description was changed from

==========
Introduce ClassLike, MemberLike, FieldLike and FunctionLike

... to prepare for replacing the current element model with kernel based
elements (for the resolution world) and Dart-in-JS elements (for
the codegen world).
==========

to

==========
Introduce ClassLike, MemberLike, FieldLike and FunctionLike

... to prepare for replacing the current element model with kernel based
elements (for the resolution world) and Dart-in-JS elements (for the codegen
world).

New classes in elements.dart.
Main changes in nodes.dart.
==========

[Johnni Winther, 2016-11-01 15:30:53]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-11-03 00:52:30]

minor comments and questions below

lgtm modulo finding a new name :)

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:135: abstract class ClassLike
extends Entity {
maybe it is too early to tell, but how much from ClassElement do you think we'll
end up having here in the end?

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:164: abstract class FunctionLike
extends MemberLike {}
I'm not yet convinced on using the "XLike" names :)

Other ideas:
- overload "Class, Member, Field", (or ClassElement, MemberELement, ...), move
them to a new library (e.g. new_elements), and always use them with a prefix
(e.g. n)
- use the "Entity" suffix instead? (e.g. "ClassEntity")

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:2341: FieldElement field =
instruction.element;
is the idea to convert all of the uses of elements in this file to use the new
simpler types?

[Johnni Winther, 2016-11-03 09:55:06]

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:135: abstract class ClassLike
extends Entity {
On 2016/11/03 00:52:30, Siggi Cherem (dart-lang) wrote:
> maybe it is too early to tell, but how much from ClassElement do you think
we'll
> end up having here in the end?

Not much: I plan to move most queries on relations to other entities (like
sub/superrelation, members) into [ClosedWorld] and similar.

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:164: abstract class FunctionLike
extends MemberLike {}
On 2016/11/03 00:52:30, Siggi Cherem (dart-lang) wrote:
> I'm not yet convinced on using the "XLike" names :)
> 
> Other ideas:
> - overload "Class, Member, Field", (or ClassElement, MemberELement, ...), move
> them to a new library (e.g. new_elements), and always use them with a prefix
> (e.g. n)
> - use the "Entity" suffix instead? (e.g. "ClassEntity")
> 

Moved to 'entities.dart', use 'Entity' as suffix.

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2464103002/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:2341: FieldElement field =
instruction.element;
On 2016/11/03 00:52:30, Siggi Cherem (dart-lang) wrote:
> is the idea to convert all of the uses of elements in this file to use the new
> simpler types?

Yes.

[Johnni Winther, 2016-11-03 09:59:39]

Description was changed from

==========
Introduce ClassLike, MemberLike, FieldLike and FunctionLike

... to prepare for replacing the current element model with kernel based
elements (for the resolution world) and Dart-in-JS elements (for the codegen
world).

New classes in elements.dart.
Main changes in nodes.dart.
==========

to

==========
Introduce ClassLike, MemberLike, FieldLike and FunctionLike

... to prepare for replacing the current element model with kernel based
elements (for the resolution world) and Dart-in-JS elements (for the codegen
world).

New classes in elements.dart.
Main changes in nodes.dart.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/db14062bab29da28762ed874ee3a29234ee3521a
==========

[Johnni Winther, 2016-11-03 09:59:41]

Committed patchset #3 (id:40001) manually as
db14062bab29da28762ed874ee3a29234ee3521a (presubmit successful).