Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2464063002: Revert of Some more pre-material cleanups (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, tfarina, James Su, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Some more pre-material cleanups (patchset #4 id:60001 of https://codereview.chromium.org/2444923003/ ) Reason for revert: Speculative revert since being the only commit in the first of a long series of flaky failures in interactive_ui_tests on Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8428 Original issue's description: > Some more pre-material cleanups > > BUG=648281 > > Committed: https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086 > Cr-Commit-Position: refs/heads/master@{#428603} TBR=groby@chromium.org,pkasting@chromium.org,sadrul@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=648281 Committed: https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a Cr-Commit-Position: refs/heads/master@{#428969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -63 lines) Patch
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/infobar_container_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/infobar_container_delegate.cc View 4 chunks +51 lines, -11 lines 0 comments Download
M chrome/browser/ui/layout_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/layout_constants.cc View 4 chunks +41 lines, -33 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 3 chunks +27 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/base/material_design/material_design_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Revert of Some more pre-material cleanups
4 years, 1 month ago (2016-11-01 09:23:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464063002/1
4 years, 1 month ago (2016-11-01 09:24:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 10:18:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a Cr-Commit-Position: refs/heads/master@{#428969}
4 years, 1 month ago (2016-11-01 10:21:43 UTC) #6
kjellander_chromium
4 years, 1 month ago (2016-11-01 13:30:17 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2466343002/ by kjellander@chromium.org.

The reason for reverting is: Relanding as newer builds experienced the same
flakiness:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8533.

Powered by Google App Engine
This is Rietveld 408576698