Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2464053005: Revert of [tools] Support custom script injection for callstats.py (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [tools] Support custom script injection for callstats.py (patchset #1 id:1 of https://codereview.chromium.org/2455623002/ ) Reason for revert: speculative revert to address regressions on cnn.com benchmark. Original issue's description: > [tools] Support custom script injection for callstats.py > > This is a poor-man's solution to trigger page interactions. > > BUG= TBR=jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/fdf0b3ee7a9f56a6511d86b5a37f78f7c1b56390 Cr-Commit-Position: refs/heads/master@{#40710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M tools/callstats.py View 3 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Camillo Bruni
Created Revert of [tools] Support custom script injection for callstats.py
4 years, 1 month ago (2016-11-02 20:15:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464053005/1
4 years, 1 month ago (2016-11-02 20:15:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 20:36:41 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdf0b3ee7a9f56a6511d86b5a37f78f7c1b56390
Cr-Commit-Position: refs/heads/master@{#40710}

Powered by Google App Engine
This is Rietveld 408576698