third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp - Issue 2464053003: Always paint background and shadow separately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

Issue 2464053003: Always paint background and shadow separately (Closed)

Patch Set: Rebaseline-cl (invisible pixel changes along shadow edges) (The original Patch Set 2 was removed to get the try result in Patch Set 1) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

index b5981585e7123f9662133707a51535b60cf426e1..9e5967225dbfca72a4a27c36a00a9bc5e1b00cbb 100644

--- a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

@@ -276,9 +276,7 @@ void InlineFlowBoxPainter::paintBoxDecorationBackground(

getBorderPaintType(adjustedFrameRect, adjustedClipRect);

// Shadow comes first and is behind the background and border.

- if (!m_inlineFlowBox.boxModelObject().boxShadowShouldBeAppliedToBackground(

- BackgroundBleedNone, &m_inlineFlowBox))

- paintBoxShadow(paintInfo, *styleToUse, Normal, adjustedFrameRect);

+ paintBoxShadow(paintInfo, *styleToUse, Normal, adjustedFrameRect);

Color backgroundColor = inlineFlowBoxLayoutObject->resolveColor(

*styleToUse, CSSPropertyBackgroundColor);

« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPainter.cpp ('k') | no next file » | no next file with comments »