third_party/WebKit/Source/core/layout/LayoutImage.cpp - Issue 2464053003: Always paint background and shadow separately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutImage.cpp

Issue 2464053003: Always paint background and shadow separately (Closed)

Patch Set: Rebaseline-cl (invisible pixel changes along shadow edges) (The original Patch Set 2 was removed to get the try result in Patch Set 1) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutImage.h ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutImage.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutImage.cpp b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

index 8a4a964ca2cad019c4e0272ee2981e186d89d6c6..85d249923cf6e620d224bae7de8aba2874b26908 100644

--- a/third_party/WebKit/Source/core/layout/LayoutImage.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

@@ -213,16 +213,6 @@ void LayoutImage::areaElementFocusChanged(HTMLAreaElement* areaElement) {

invalidatePaintAndMarkForLayoutIfNeeded();

}

-bool LayoutImage::boxShadowShouldBeAppliedToBackground(

- BackgroundBleedAvoidance bleedAvoidance,

- const InlineFlowBox*) const {

- if (!LayoutBoxModelObject::boxShadowShouldBeAppliedToBackground(

- bleedAvoidance))

- return false;

- return !const_cast<LayoutImage*>(this)->backgroundIsKnownToBeObscured();

bool LayoutImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect,

unsigned) const {

if (!m_imageResource->hasImage() || m_imageResource->errorOccurred())

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutImage.h ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.h » ('j') | no next file with comments »