Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2464053003: Always paint background and shadow separately (Closed)
Patch Set: Rebaseline-cl (invisible pixel changes along shadow edges) (The original Patch Set 2 was removed to get the try result in Patch Set 1) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1338 matching lines...) Expand 10 before | Expand all | Expand 10 after
1349 const PaintInfo& paintInfo, 1349 const PaintInfo& paintInfo,
1350 const LayoutPoint& paintOffset) const { 1350 const LayoutPoint& paintOffset) const {
1351 TableCellPainter(*this).paintBoxDecorationBackground(paintInfo, paintOffset); 1351 TableCellPainter(*this).paintBoxDecorationBackground(paintInfo, paintOffset);
1352 } 1352 }
1353 1353
1354 void LayoutTableCell::paintMask(const PaintInfo& paintInfo, 1354 void LayoutTableCell::paintMask(const PaintInfo& paintInfo,
1355 const LayoutPoint& paintOffset) const { 1355 const LayoutPoint& paintOffset) const {
1356 TableCellPainter(*this).paintMask(paintInfo, paintOffset); 1356 TableCellPainter(*this).paintMask(paintInfo, paintOffset);
1357 } 1357 }
1358 1358
1359 bool LayoutTableCell::boxShadowShouldBeAppliedToBackground(
1360 BackgroundBleedAvoidance,
1361 const InlineFlowBox*) const {
1362 return false;
1363 }
1364
1365 void LayoutTableCell::scrollbarsChanged(bool horizontalScrollbarChanged, 1359 void LayoutTableCell::scrollbarsChanged(bool horizontalScrollbarChanged,
1366 bool verticalScrollbarChanged) { 1360 bool verticalScrollbarChanged) {
1367 LayoutBlock::scrollbarsChanged(horizontalScrollbarChanged, 1361 LayoutBlock::scrollbarsChanged(horizontalScrollbarChanged,
1368 verticalScrollbarChanged); 1362 verticalScrollbarChanged);
1369 int scrollbarHeight = scrollbarLogicalHeight(); 1363 int scrollbarHeight = scrollbarLogicalHeight();
1370 // Not sure if we should be doing something when a scrollbar goes away or not. 1364 // Not sure if we should be doing something when a scrollbar goes away or not.
1371 if (!scrollbarHeight) 1365 if (!scrollbarHeight)
1372 return; 1366 return;
1373 1367
1374 // We only care if the scrollbar that affects our intrinsic padding has been 1368 // We only care if the scrollbar that affects our intrinsic padding has been
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
1453 cb->adjustChildDebugRect(rect); 1447 cb->adjustChildDebugRect(rect);
1454 1448
1455 return rect; 1449 return rect;
1456 } 1450 }
1457 1451
1458 void LayoutTableCell::adjustChildDebugRect(LayoutRect& r) const { 1452 void LayoutTableCell::adjustChildDebugRect(LayoutRect& r) const {
1459 r.move(0, -intrinsicPaddingBefore()); 1453 r.move(0, -intrinsicPaddingBefore());
1460 } 1454 }
1461 1455
1462 } // namespace blink 1456 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698