Source/core/rendering/RenderBlock.cpp - Issue 246403015: [New Multicolumn] Create RenderMultiColumnSet during renderer creation, not during layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 246403015: [New Multicolumn] Create RenderMultiColumnSet during renderer creation, not during layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index d2a9fb2800c3ead3762804f124bce65729485cfb..5b4bf6088f5ef564d2ba1a63e91cd6c2d2e10ef8 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -4709,7 +4709,7 @@ RenderRegion* RenderBlock::regionAtBlockOffset(LayoutUnit blockOffset) const

if (!flowThread || !flowThread->hasValidRegionInfo())

return 0;

- return flowThread->regionAtBlockOffset(offsetFromLogicalTopOfFirstPage() + blockOffset, true);

+ return flowThread->regionAtBlockOffset(offsetFromLogicalTopOfFirstPage() + blockOffset);

}

LayoutUnit RenderBlock::collapsedMarginBeforeForChild(const RenderBox* child) const

« no previous file with comments | « no previous file | Source/core/rendering/RenderFlowThread.h » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')