Issue 246403004: Remove guards Chromium no longer needs

Issue 246403004: Remove guards Chromium no longer needs (Closed)

Created:
6 years, 8 months ago by robertphillips

Modified:
6 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, scroggo

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Remove guards Chromium no longer needs Note: Android still needs these guards. Committed: http://code.google.com/p/skia/source/detail?r=14299 Committed: http://code.google.com/p/skia/source/detail?r=14329

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 10 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 8 months ago (2014-04-22 15:14:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/246403004/1

6 years, 8 months ago (2014-04-22 15:15:06 UTC) #4

robertphillips

This was reverted in r14311 due to a race condition with Chrome-side change (Switching unit ...

6 years, 8 months ago (2014-04-22 19:54:20 UTC) #6

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 8 months ago (2014-04-23 12:30:46 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/246403004/1

6 years, 8 months ago (2014-04-23 12:30:58 UTC) #8

robertphillips

Recommitting since (Switching unit tests to use new Skia SkPictureRecorder API - https://codereview.chromium.org/246393005/) has landed ...

6 years, 8 months ago (2014-04-23 12:31:22 UTC) #9

Message was sent while issue was closed.

Change committed as 14329