Implement support for chorded braille commands

chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc

Index: chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
diff --git a/chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc b/chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
index 1e8a9530699e84a6c938ed339f040f22b41ba2d7..0b7a2143eac7a5452595180632c025be327b16d2 100644
--- a/chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
+++ b/chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
@@ -142,8 +142,12 @@ void MapCommand(brlapi_keyCode_t code, KeyEvent* event) {
           event->display_position.reset(new int(argument));
           break;
         case BRLAPI_KEY_CMD_PASSDOTS:
-          event->command = KEY_COMMAND_DOTS;
-          event->braille_dots.reset(new int(argument & kAllDots));
+          unsigned int dots = argument & kAllDots;
+          event->braille_dots.reset(new int(dots));
+          if (dots && argument & BRLAPI_DOTC)

[dmazzoni, 2016/11/01 16:22:37]

nit: I prefer parens around the bitwise and clause to make it
totally unambiguous, it's easy to misread

Also, please add a comment // BRLAPI_DOTC means space is held down

[David Tseng, 2016/11/01 20:11:59]

Done.

+          event->command = KEY_COMMAND_CHORD;
+          else
+                      event->command = KEY_COMMAND_DOTS;

[dmazzoni, 2016/11/01 16:23:04]

nit: indentation of this line and two lines previous

[David Tseng, 2016/11/01 20:11:59]

Done.

           MapModifierFlags(code, event);
           break;
       }