Implement support for chorded braille commands

Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions as set implicitly by various generations of braille notetakers, mobile screen readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific hardware devices upstream in Brltty. We still utilize hardware mappings there in Chrome OS, but will soon pass through any keys that involve the braille space key.

note2: this change depends on my patch against Brltty to extract the raw chords. It is, however, not blocked by the below patch.
https://chromium-review.googlesource.com/#/c/406528/

Only after both patches land, will braille chording work.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
Committed: https://crrev.com/6c0b858a61fc872a976b18e63f653d5524992ab3
Cr-Commit-Position: refs/heads/master@{#430083}

[David Tseng, 2016-10-31 22:33:52]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-31 22:39:22]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-31 22:39:23]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-10-31 22:44:12]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

[David Tseng, 2016-10-31 23:41:32]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

BUG=

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

[David Tseng, 2016-11-01 02:37:54]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 02:38:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 03:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 03:33:51]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-11-01 16:22:38]

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc:147:
if (dots && argument & BRLAPI_DOTC)
nit: I prefer parens around the bitwise and clause to make it
totally unambiguous, it's easy to misread

Also, please add a comment // BRLAPI_DOTC means space is held down

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:542:
break;
nit: indentation

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:54:
map([2, 3], 'previousGroup');
Would it be possible to put this mapping into next_keymap.json instead?
I think it'd make more sense to put the keyboard and braille maps
together in one place to encourage mapping them together.

[dmazzoni, 2016-11-01 16:23:04]

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc:150:
event->command = KEY_COMMAND_DOTS;
nit: indentation of this line and two lines previous

[David Tseng, 2016-11-01 20:11:59]

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc:147:
if (dots && argument & BRLAPI_DOTC)
On 2016/11/01 16:22:37, dmazzoni wrote:
> nit: I prefer parens around the bitwise and clause to make it
> totally unambiguous, it's easy to misread
> 
> Also, please add a comment // BRLAPI_DOTC means space is held down

Done.

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc:150:
event->command = KEY_COMMAND_DOTS;
On 2016/11/01 16:23:04, dmazzoni wrote:
> nit: indentation of this line and two lines previous

Done.

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:542:
break;
On 2016/11/01 16:22:37, dmazzoni wrote:
> nit: indentation

Done.

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
(right):

https://codereview.chromium.org/2463983002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:54:
map([2, 3], 'previousGroup');
On 2016/11/01 16:22:37, dmazzoni wrote:
> Would it be possible to put this mapping into next_keymap.json instead?
> I think it'd make more sense to put the keyboard and braille maps
> together in one place to encourage mapping them together.
> 

I would like to eventually move away from the way classic handles the keyboard.
To do what you suggest would mean touching KeyUtil, KeySequence, and probably
more. Much of the complexity comes from handling things like prefix key,
sequencing, etc. I think we want to have one keymap/braillemap, perhaps defined
in code.

[David Tseng, 2016-11-02 02:41:45]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.

Cros patch:
https://chromium-review.googlesource.com/#/c/406528/

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

[David Tseng, 2016-11-02 19:38:51]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords
and should only land after a patched (or a fully merged) Brltty lands in Cros.

Cros patch:
https://chromium-review.googlesource.com/#/c/406528/

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords.
It is, however, not blocked by the below patch.
https://chromium-review.googlesource.com/#/c/406528/

Only after both patches land, will braille chording work.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

[David Tseng, 2016-11-02 19:39:20]

Friendly ping; Chrome OS patch is already ready but not blocking this cl.

[dmazzoni, 2016-11-02 19:42:19]

lgtm

[David Tseng, 2016-11-02 19:46:28]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-11-02 19:47:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 19:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 19:56:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Tseng, 2016-11-02 21:25:00]

dtseng@chromium.org changed reviewers:
+ rdevlin@chromium.org

[David Tseng, 2016-11-02 21:25:00]

+ rdevlin for OWNERS.

[David Tseng, 2016-11-03 22:19:07]

On 2016/11/02 21:25:00, David Tseng wrote:
> + rdevlin for OWNERS.

Adding: @rdevlin, just for small change in braille_display_private.idl

[David Tseng, 2016-11-04 18:19:23]

dtseng@chromium.org changed reviewers:
+ asargent@chromium.org
- rdevlin@chromium.org

[David Tseng, 2016-11-04 18:19:24]

Trying different owner
+ asargentfor braille display private.idl

[asargent_no_longer_on_chrome, 2016-11-04 19:52:35]

extensions parts lgtm

https://codereview.chromium.org/2463983002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc
(right):

https://codereview.chromium.org/2463983002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc:146:
event->braille_dots.reset(new int(dots));
nit: consider using base::MakeUnique, which I think is now preferred to bare
"new" calls

event->braille_dots = base::MakeUnique<int>(dots);

[David Tseng, 2016-11-04 22:35:52]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:37:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:26:02]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords.
It is, however, not blocked by the below patch.
https://chromium-review.googlesource.com/#/c/406528/

Only after both patches land, will braille chording work.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords.
It is, however, not blocked by the below patch.
https://chromium-review.googlesource.com/#/c/406528/

Only after both patches land, will braille chording work.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

[commit-bot: I haz the power, 2016-11-05 00:26:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-05 00:27:57]

Description was changed from

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords.
It is, however, not blocked by the below patch.
https://chromium-review.googlesource.com/#/c/406528/

Only after both patches land, will braille chording work.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671
==========

to

==========
Implement support for chorded braille commands

This cl adds a new type of braille command which is a subtype of
BRLAPI_PASSDOTS.

Once received, map the raw dot pattern to a command using standard conventions
as set implicitly by various generations of braille notetakers, mobile screen
readers, and other braille related applications.

Note1: this approach improves on that taken by other clients that patch specific
hardware devices upstream in Brltty. We still utilize hardware mappings there in
Chrome OS, but will soon pass through any keys that involve the braille space
key.

note2: this change depends on my patch against Brltty to extract the raw chords.
It is, however, not blocked by the below patch.
https://chromium-review.googlesource.com/#/c/406528/

Only after both patches land, will braille chording work.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=633671

Committed: https://crrev.com/6c0b858a61fc872a976b18e63f653d5524992ab3
Cr-Commit-Position: refs/heads/master@{#430083}
==========

[commit-bot: I haz the power, 2016-11-05 00:28:00]

Patchset 3 (id:??) landed as
https://crrev.com/6c0b858a61fc872a976b18e63f653d5524992ab3
Cr-Commit-Position: refs/heads/master@{#430083}