Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2463963002: Fix bool / int mismatch for win64 (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/fxge/win32/fx_win32_print.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
Lei, for review. Looks like I missed one, and that this blocked the roll with ...
4 years, 1 month ago (2016-10-31 21:24:40 UTC) #4
Lei Zhang
lgtm My fault. Code is behind an ifdef.
4 years, 1 month ago (2016-10-31 21:28:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463963002/1
4 years, 1 month ago (2016-10-31 21:33:52 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 21:34:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/da3447b5a8c1baffacf485461b0169f77870...

Powered by Google App Engine
This is Rietveld 408576698