third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl - Issue 2463953002: Expose RTCDataChannel and RTCDataChannelEvent (with constructor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl

Issue 2463953002: Expose RTCDataChannel and RTCDataChannelEvent (with constructor) (Closed)

Patch Set: Partially editted tests expected results Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.cpp ('k') | third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEventInit.idl » ('j') | third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEventInit.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl b/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl

index 0a724076afb22d0251d5ddfb97e55928e7146044..4307c1b8c2131e651932951228a1b91a1bd00dab 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl

@@ -25,10 +25,8 @@

// https://w3c.github.io/webrtc-pc/#rtcdatachannelevent

-// TODO(foolip): RTCDataChannelEvent should have a constructor. See also

-// https://github.com/w3c/webrtc-pc/issues/817

[

- NoInterfaceObject

+ Constructor(DOMString type, RTCDataChannelEventInit eventInitDict),

] interface RTCDataChannelEvent : Event {

readonly attribute RTCDataChannel channel;

};