third_party/WebKit/LayoutTests/fast/peerconnection/RTCDataChannelEvent-constructor.html - Issue 2463953002: Expose RTCDataChannel and RTCDataChannelEvent (with constructor)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCDataChannelEvent-constructor.html

Issue 2463953002: Expose RTCDataChannel and RTCDataChannelEvent (with constructor) (Closed)

Patch Set: Added layout test for constructor and fixed expected output for global-listing Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>RTCDataChannelEvent constructor</title>

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script>

	7 test(function() {

	8 assert_equals(RTCDataChannelEvent.length, 2);

	9 assert_throws(new TypeError(), function() { new RTCDataChannelEvent('type'); });
	foolip 2016/11/08 20:36:43 Here, can you also test that these two throw TypeE Here, can you also test that these two throw TypeError: new RTCDataChannelEvent('type', { channel: null }); new RTCDataChannelEvent('type', { channel: undefined }); With that the description wouldn't be pedantically correct, so maybe "RTCDataChannelEvent constructor without channel". (Having "Test for" or "Checks for" in the test name isn't uncommon, but I like to leave it out. Feel free to go with whatever you like.) lunalu1 2016/11/11 15:37:27 Done. Show quoted text On 2016/11/08 20:36:43, foolip wrote: > Here, can you also test that these two throw TypeError: > new RTCDataChannelEvent('type', { channel: null }); > new RTCDataChannelEvent('type', { channel: undefined }); > > With that the description wouldn't be pedantically correct, so maybe > "RTCDataChannelEvent constructor without channel". (Having "Test for" or "Checks > for" in the test name isn't uncommon, but I like to leave it out. Feel free to > go with whatever you like.) Done.
	10 }, 'Checks for RTCDataChannelEvent constructor without a required argument.');

	11

	12 test(function() {

	13 var pc = new RTCPeerConnection();

	14 var c = pc.createDataChannel('');

	15 var e = new RTCDataChannelEvent('type', {channel: c});

	16 assert_true(e instanceof RTCDataChannelEvent);

	17 assert_equals(e.channel, c);

	18 }, 'Checks for RTCDataChannelEvent constructor with full arguments.');

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »