Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 246393013: Revert of Properly enable S32_D16_filter_DX_SSE2 optimization. (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Properly enable S32_D16_filter_DX_SSE2 optimization. (https://codereview.chromium.org/239453010/) Reason for revert: Broke GMs in 565 mode. To repro: out/Debug/gm --match filterbitmap_image_mandrill -w . --config 565 open filterbitmap_image_mandrill_512.png_565.png Original issue's description: > Properly enable S32_D16_filter_DX_SSE2 optimization. > > Currently, the S32_D16_filter_DX_SSE2 optimization is only used in > configurations where the maximum SSE level is SSE2. > This patch enables it for higher levels, as well. > Also, refactored the function a bit, to make future modifications > less error-prone. > > Author: henrik.smiding@intel.com > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; > > Committed: http://code.google.com/p/skia/source/detail?r=14333 TBR=reed@google.com,mtklein@google.com,tomhudson@google.com,djsollen@google.com,joakim.landberg@intel.com,henrik.smiding@intel.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -44 lines) Patch
M src/opts/opts_check_SSE2.cpp View 1 chunk +36 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Properly enable S32_D16_filter_DX_SSE2 optimization.
6 years, 8 months ago (2014-04-23 20:07:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/246393013/1
6 years, 8 months ago (2014-04-23 20:07:14 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 20:07:20 UTC) #3
Message was sent while issue was closed.
Change committed as 14336

Powered by Google App Engine
This is Rietveld 408576698