Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 246393010: Replaced FormatMessage(FORMAT_MESSAGE_FROM_SYSTEM) with logging::SystemErrorCodeToString. (Closed)

Created:
6 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 8 months ago
Reviewers:
keybuk, Nico, rpaquay
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replaced FormatMessage(FORMAT_MESSAGE_FROM_SYSTEM) with logging::SystemErrorCodeToString. R=rpaquay@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266192

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M chrome/browser/platform_util_win.cc View 1 chunk +1 line, -8 lines 0 comments Download
M device/bluetooth/bluetooth_socket_win.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Vitaly Buka (NO REVIEWS)
Format is a little bit different, but I guess it does not matter there. Ex: ...
6 years, 8 months ago (2014-04-23 01:40:48 UTC) #1
Nico
The old code logged the hresult too. Are you dropping that intentionally? lgtm either way.
6 years, 8 months ago (2014-04-23 03:11:53 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2014/04/23 03:11:53, Nico wrote: > The old code logged the hresult too. Are you ...
6 years, 8 months ago (2014-04-23 05:27:18 UTC) #3
keybuk
+rpaquay
6 years, 8 months ago (2014-04-24 11:35:27 UTC) #4
rpaquay
lgtm
6 years, 8 months ago (2014-04-24 18:18:53 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-25 01:03:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/246393010/20001
6 years, 8 months ago (2014-04-25 01:04:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 02:18:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 02:18:17 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-25 04:51:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/246393010/20001
6 years, 8 months ago (2014-04-25 08:23:03 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 8 months ago (2014-04-25 15:05:04 UTC) #12
Vitaly Buka (NO REVIEWS)
6 years, 8 months ago (2014-04-25 15:33:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r266192 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698