Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 246393009: Revert of [repaint-after-layout] Skip full repaint if the style difference is layout. (Closed)

Created:
6 years, 8 months ago by dsinclair
Modified:
6 years, 8 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Revert of [repaint-after-layout] Skip full repaint if the style difference is layout. (https://codereview.chromium.org/211613002/) Reason for revert: Breaks fast/repaint/positioned-document-element.html. Original issue's description: > [repaint-after-layout] Skip full repaint if the style difference is layout. > > Currently in RenderBox::styleWillChange we will issue a view()->repaint() if the > node is the HTML or body element and the diff >= StyleDifferenceRepaint. For > repaint-after-layout, if this is StyleDifferenceLayout, we will do the layout > and end up issuing the same invalidation again. > > This CL makes the view()->repaint() call conditional on either > 1) repaint-after-layout is disabled > 2) this is not a StyleDifferenceLayout. > > BUG=320139 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169984 TBR=esprehn@chromium.org,jchaffraix@chromium.org,eseidel@chromium.org,ojan@chromium.org NOTREECHECKS=true NOTRY=true BUG=320139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
Created Revert of [repaint-after-layout] Skip full repaint if the style difference is layout.
6 years, 8 months ago (2014-04-22 23:38:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/246393009/1
6 years, 8 months ago (2014-04-22 23:38:48 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 23:51:51 UTC) #3
Message was sent while issue was closed.
Change committed as 172291

Powered by Google App Engine
This is Rietveld 408576698