Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 246393008: Add literal picture recording mode, triggered by a compile time switch. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add literal picture recording mode, triggered by a compile time switch. This is helpful to record SKPs from Chrome as a fair bootstrapping source for SkRecord. Without this sort of switch, a good bit of SkPicture's cleverness is baked into the SKP, and thus SkRecord looks unfairly good. Tested by defining SK_RECORD_LITERAL_PICTURES and running dm --match ~optimizations. By design that GM will never pass in literal mode. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14547

Patch Set 1 #

Patch Set 2 : stray newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M src/core/SkPictureRecord.cpp View 1 12 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 8 months ago (2014-04-22 22:19:16 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-02 20:14:28 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-02 20:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/246393008/20001
6 years, 7 months ago (2014-05-02 20:19:17 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 20:27:51 UTC) #5
Message was sent while issue was closed.
Change committed as 14547

Powered by Google App Engine
This is Rietveld 408576698